fix(registry): normalize legacy table search payloads#2197
Merged
Conversation
daryllimyt
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TablesClient.search_rows()accepted either a raw list or a paginated dict containingitems, and raisedValueError("Unexpected search response")for other dict shapes; some deployments still return paginated payloads keyed asrows, causing executor failures when callingtracecat_registry.core.table.search_rows.Description
packages/tracecat-registry/tracecat_registry/sdk/tables.py::TablesClient.search_rowsto accept the canonicalitemspaginated payload and to normalize legacyrows-based paginated payloads into atypes.TableSearchResponseshape while preserving existing validation.rows->itemsand forwardsnext_cursor,prev_cursor,has_more,has_previous, and optionaltotal_estimateinto the returned response.tests/registry/test_tables_sdk.pythat verify normalization of the legacyrowspayload and that unexpected dict shapes still raiseValueError("Unexpected search response").Testing
uv run ruff check packages/tracecat-registry/tracecat_registry/sdk/tables.py tests/registry/test_tables_sdk.pywhich passed.uv run pytest tests/registry/test_tables_sdk.py tests/registry/test_core_table.py -q, but the run failed in this environment due to missing PostgreSQL onlocalhost:5432required by test fixtures, preventing a full test run here.Codex Task
Summary by cubic
Normalize legacy table search responses in TablesClient.search_rows to support old "rows" pagination alongside "items". This prevents executor errors on deployments that still return "rows".
Written for commit 95d899c. Summary will update on new commits.