fix(org): add passive_deletes to User relationships for member removal#2196
Merged
jordan-umusu merged 1 commit intomainfrom Feb 26, 2026
Merged
fix(org): add passive_deletes to User relationships for member removal#2196jordan-umusu merged 1 commit intomainfrom
jordan-umusu merged 1 commit intomainfrom
Conversation
daryllimyt
approved these changes
Feb 26, 2026
daryllimyt
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrgService.delete_member()failed with aNOT NULLconstraint violation onaccess_token.user_id(andother child FKs like
user_role_assignment.user_id)SET NULLon child foreign keys to de-associate them — butthese columns are non-nullable, causing the error
passive_deletes=Trueto User relationships (access_tokens,chats,role_assignments,organizations) soSQLAlchemy defers to the existing database-level
ON DELETE CASCADEconstraints instead of attempting to nullify the foreignkeys
Summary by cubic
Set passive_deletes=True on User relationships (AccessToken, Chat, UserRoleAssignment, and Organization memberships) to rely on DB cascades during deletion and membership removal. Prevents foreign key violations and unnecessary ORM deletes when removing a user from an organization.
Written for commit 2ea1859. Summary will update on new commits.