feat(ui): Add workflow feed with filtering and pagination#2195
feat(ui): Add workflow feed with filtering and pagination#2195
Conversation
8df1fdf to
b060948
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8df1fdf567
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
2 issues found across 19 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/hooks/pagination/use-cursor-pagination.tsx">
<violation number="1" location="frontend/src/hooks/pagination/use-cursor-pagination.tsx:73">
P1: Remove ineffective `useMemo` and replace `useEffect` with a render-phase state update to prevent a 'ghost fetch' with invalid cursors. (Consider applying this pattern to the limit and sorting effects as well).</violation>
</file>
<file name="frontend/src/components/dashboard/workflows-header.tsx">
<violation number="1" location="frontend/src/components/dashboard/workflows-header.tsx:132">
P2: When a custom date range is cleared in the calendar, the parent component is not notified, causing the filter UI to get out of sync with the internal state.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
3 issues found across 14 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/components/cases/cases-layout.tsx">
<violation number="1" location="frontend/src/components/cases/cases-layout.tsx:315">
P2: The `hasExplicitSort` evaluation misses `dropdownFilters` sort directions, causing cases sorted by dropdowns to be improperly grouped.</violation>
</file>
<file name="frontend/src/hooks/use-cases.ts">
<violation number="1" location="frontend/src/hooks/use-cases.ts:251">
P2: Clearing the priority or severity sort does not reset the underlying `sortBy` state, causing the API to continue returning sorted results.</violation>
</file>
<file name="frontend/src/components/dashboard/workflows-dashboard.tsx">
<violation number="1" location="frontend/src/components/dashboard/workflows-dashboard.tsx:477">
P1: Client-side sorting and searching are being applied to a single server-paginated page, causing sorts and filters to only affect the currently loaded subset of workflows.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
2 issues found across 16 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/components/dashboard/workflow-tags-table.tsx">
<violation number="1" location="frontend/src/components/dashboard/workflow-tags-table.tsx:95">
P1: Make `AlertDialog` controlled to prevent permanent UI lock after editing.</violation>
<violation number="2" location="frontend/src/components/dashboard/workflow-tags-table.tsx:242">
P2: Prevent default behavior on `AlertDialogAction` to keep dialog open during async deletion.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
@cursor review |
|
@codex review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable autofix in the Cursor dashboard.
| await workflowsRemoveTag(params), | ||
| onSuccess: () => { | ||
| queryClient.invalidateQueries({ queryKey: ["workflows", workspaceId] }) | ||
| queryClient.invalidateQueries({ queryKey: ["workflows"] }) |
There was a problem hiding this comment.
Move workflow does not invalidate list view cache
Medium Severity
The moveWorkflow mutation invalidates only directory-items; it does not invalidate workflows queries. The new list view uses useWorkflowsPagination, which depends on ["workflows", "paginated", ...]. Moving a workflow from the list view leaves the list stale until the cache expires or the user navigates away.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2981ae7f1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
1 issue found across 11 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tracecat/workflow/management/types.py">
<violation number="1" location="tracecat/workflow/management/types.py:159">
P2: Fix trigger summary visibility bug where offline schedules are omitted unless webhooks/case triggers are active.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/components/dashboard/workflows-dashboard.tsx">
<violation number="1" location="frontend/src/components/dashboard/workflows-dashboard.tsx:1234">
P2: The empty state text incorrectly assumes the user is always in 'folders' view mode, which will display a confusing message when in 'list' mode.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Summary
cases-feed, adding filters for tags, created, and updated dates, badges for alias/updated/published/version metadata, and view switching between list and folder modes.Testing
Summary by cubic
Adds a unified Workflows feed with tag/date filters, search, sort, cursor pagination, and trigger badges. Replaces folder views, adds tag management with a catalog toggle, fixes schedule filters and webhook layout, adds a Cases sort dropdown, and introduces an empty state for the workflows dashboard.
New Features
Refactors
Written for commit ec1f721. Summary will update on new commits.