Skip to content

fix(agents): read tool schema from manifest#2193

Merged
jordan-umusu merged 2 commits intomainfrom
fix/agent-tool-manifest-schema
Feb 25, 2026
Merged

fix(agents): read tool schema from manifest#2193
jordan-umusu merged 2 commits intomainfrom
fix/agent-tool-manifest-schema

Conversation

@jordan-umusu
Copy link
Collaborator

@jordan-umusu jordan-umusu commented Feb 25, 2026

Summary by cubic

Read tool descriptions and parameter schemas from the registry manifest and validate the schema shape to avoid importing action modules. Fixes tool creation for custom/git-synced UDF actions and prevents invalid tools from malformed manifests.

  • Bug Fixes
    • Use manifest.interface.expects for parameters and require a valid JSON Schema (must include 'type' or 'properties'); raise a clear error if malformed.
    • Removed _extract_action_metadata and related tests; create_tool_from_registry now reads description and schema directly from the manifest.

Written for commit f9f93ac. Summary will update on new commits.

@jordan-umusu jordan-umusu added fix Bug fix agents LLM agents labels Feb 25, 2026
@jordan-umusu jordan-umusu marked this pull request as ready for review February 25, 2026 21:56
@jordan-umusu jordan-umusu changed the title fix(agents): read tool schema from manifest instead of importing acti… fix(agents): read tool schema from manifest Feb 25, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a96f5d4cb5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Contributor

@daryllimyt daryllimyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jordan-umusu jordan-umusu merged commit d4e6128 into main Feb 25, 2026
17 checks passed
@jordan-umusu jordan-umusu deleted the fix/agent-tool-manifest-schema branch February 25, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents LLM agents fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants