fix(rbac): scope seeding for new orgs#2176
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33506eb998
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tracecat/organization/management.py">
<violation number="1" location="tracecat/organization/management.py:74">
P2: Committing inside ensure_organization_defaults breaks transaction boundaries for callers and can leave partially-initialized orgs if later steps fail. Prefer letting the caller manage the commit and keep defaults initialization atomic.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
topher-lo
approved these changes
Feb 25, 2026
daryllimyt
pushed a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
until the next restart
seed_system_roles_for_org()from the bulk startup seeder and call it inensure_organization_defaults(), so roles are upserted at org creation timeON CONFLICT DO UPDATE, existing role-scope links are skipped viaON CONFLICT DO NOTHINGQA
organization-owner,organization-admin,organization-member,workspace-admin,workspace-editor,workspace-viewer) with correct scope assignmentsensure_default_organization) still workSummary by cubic
Fixes RBAC scope seeding for new organizations by seeding preset roles and role-scope links during org initialization. Commits the default workspace and seeded roles before tier assignment so new orgs have complete roles and permissions immediately.
Bug Fixes
Refactors
Written for commit aae6f27. Summary will update on new commits.