Unbreak LRE Remote workflow#1058
Merged
aaronmondal merged 1 commit intoTraceMachina:mainfrom Jun 26, 2024
Merged
Conversation
The failures were caused by "ambiguous directory permission" errors from git. Locally this was hard to notice because local permissions might've been different and the infra is set up in a way that it reuses previous images. Long-term we should implement a proper mechanism to make the git repo available to cluster-internal Tekton steps. Fixes TraceMachina#986
adam-singer
approved these changes
Jun 26, 2024
Contributor
adam-singer
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable
MarcusSorealheis
pushed a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 3, 2025
The failures were caused by "ambiguous directory permission" errors from git. Locally this was hard to notice because local permissions might've been different and the infra is set up in a way that it reuses previous images. Long-term we should implement a proper mechanism to make the git repo available to cluster-internal Tekton steps. Fixes TraceMachina#986
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failures were caused by "ambiguous directory permission" errors from git. Locally this was hard to notice because local permissions might've been different and the infra is set up in a way that it reuses previous images.
Long-term we should implement a proper mechanism to make the git repo available to cluster-internal Tekton steps.
Fixes #986
This change is