Prevent renaming town/nation files when name is invalid#8137
Merged
Conversation
LlmDl
approved these changes
Mar 10, 2026
LlmDl
approved these changes
Mar 10, 2026
LlmDl
added a commit
that referenced
this pull request
Mar 10, 2026
- Prevent renaming town/nation files when name is invalid, courtesy of Warrior with PR #8137. - Flatfile databases which loaded towns/nations with invalid names could result in a town/nation file being created with a name instead of a UUID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
(only affects flatfile databases)
Spotted by Llmdl, towns & nations files are no longer name-based when using flatfile, so we shouldn't be renaming them back to a name. Nations with bad names were also being re-registered with a different UUID, which is bad.
Added internal to the name replacement map since it is, for now it's still necessary for the rare case someone has a pre-uuid db with a town with an invalid name and is updating to a newer version.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.