Skip proximity checks when minimum plot distance is set to 0#8087
Merged
LlmDl merged 1 commit intoTownyAdvanced:masterfrom Jan 24, 2026
Merged
Skip proximity checks when minimum plot distance is set to 0#8087LlmDl merged 1 commit intoTownyAdvanced:masterfrom
LlmDl merged 1 commit intoTownyAdvanced:masterfrom
Conversation
LlmDl
reviewed
Jan 24, 2026
Member
LlmDl
left a comment
There was a problem hiding this comment.
There's other types of min distance measurements, as well as a max distance setting. Does this break functionality for servers which use those but not the setting you're bypassing for?
Contributor
Author
|
No, this should not break functionality in any way, as my commit only eliminates unnecessary checks, which when there are a large number of TownBlocks, simply crash the server. |
LlmDl
approved these changes
Jan 24, 2026
Member
LlmDl
left a comment
There was a problem hiding this comment.
Looks like you are correct, thank you the Pull Request.
LlmDl
added a commit
that referenced
this pull request
Jan 24, 2026
- Bump me.clip:placeholderapi from 2.11.6 to 2.11.7. - Bump org.apache.commons:commons-compress from 1.26.2 to 1.28.0. - Fix the mayor succession event not being fired, courtesy of Warrior with PR #8086. - Skip proximity checks when minimum plot distance is set to 0, courtesy of MakcNmk with PR #8087. (First-Time Contributor!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Early return optimization for AreaSelectionUtil.filterInvalidProximityTownBlocks()
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.