Skip to content

Add null checks to the task schedulers#8060

Merged
LlmDl merged 1 commit intomasterfrom
fix/task-scheduler-null-checks
Jan 8, 2026
Merged

Add null checks to the task schedulers#8060
LlmDl merged 1 commit intomasterfrom
fix/task-scheduler-null-checks

Conversation

@Warriorrrr
Copy link
Copy Markdown
Member

Description:

When any one of these methods is somehow passed a null task/runnable, it causes a pretty hard to debug exception since the stacktrace does not show what method passed null to it. This PR adds checkArgument calls to every method, to make it possible to find what bad method may be passing null accidentally.


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@Warriorrrr Warriorrrr added this to the 0.102.1.0 milestone Jan 7, 2026
@LlmDl LlmDl merged commit 5b4a97c into master Jan 8, 2026
3 checks passed
@LlmDl LlmDl deleted the fix/task-scheduler-null-checks branch January 8, 2026 15:16
LlmDl added a commit that referenced this pull request Jan 8, 2026
  - Bump org.apache.maven.plugins:maven-surefire-plugin from 3.5.2 to
3.5.4.
  - Bump org.apache.maven.plugins:maven-jar-plugin from 3.4.2 to 3.5.0.
  - Bump org.apache.maven.plugins:maven-compiler-plugin from 3.13.0 to
3.14.1.
  - Bump org.apache.logging.log4j:log4j-core from 2.24.3 to 2.25.3.
  - Bump org.apache.maven.plugins:maven-shade-plugin from 3.6.0 to
3.6.1.
  - Lazily initialize maps used by TownBlock, courtesy of Warrior with
PR #8049.
  - Fix occasions where plot groups exist in townblocks being removed.
  - Fix the townyperms group command not working with capitalized
groups, courtesy of Warrior with PR #8055.
  - Add support for enabling conquering on a town via townyadmin
command.
  - Check the chunk is still wilderness after confirmation in /town new,
courtesy of Veyronity with PR #8059. (First-Time Contributor!)
  - Add null checks to the task schedulers, courtesy of Warrior with
PR #8060.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants