Reduce allocations done by Resident hasRank methods#8037
Merged
Conversation
LlmDl
reviewed
Dec 13, 2025
LlmDl
approved these changes
Dec 13, 2025
LlmDl
added a commit
that referenced
this pull request
Jan 2, 2026
Warrior with PR #8037. - Fix a logic error in the PlotGroup#setResident function, courtesy of Remasuri with PR #8043. - Bit pack perms in TownyPermission objects, courtesy of Warrior with PR #8048. - Remove world references stored inside WorldCoord, courtesy of Warrior with PR #8050. - Fix message when attempting to overclaim your own town, courtesy of Warrior with PR #8051.
1 task
LlmDl
added a commit
that referenced
this pull request
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Getting all residents in a town/nation with a specific rank goes through the Resident#hasRank method, which can allocate quite a bit total since it has to read all the ranks names from the config object.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.