Add config option: max_active_siege_attacks_per_nation_use_levels#1017
Merged
LlmDl merged 4 commits intoTownyAdvanced:masterfrom Mar 17, 2026
Merged
Conversation
LlmDl
reviewed
Mar 17, 2026
src/main/java/com/gmail/goosius/siegewar/settings/SiegeWarSettings.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/settings/ConfigNodes.java
Outdated
Show resolved
Hide resolved
LlmDl
requested changes
Mar 17, 2026
Member
|
Looks like you'll have to do the suggestions, I don't have permission on this repo... Just click the suggestions in the browser to add them to a commit. |
…ings.java Co-authored-by: LlmDl <LlmDlio@gmail.com>
…java Co-authored-by: LlmDl <LlmDlio@gmail.com>
LlmDl
requested changes
Mar 17, 2026
src/main/java/com/gmail/goosius/siegewar/settings/ConfigNodes.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: LlmDl <LlmDlio@gmail.com>
LlmDl
approved these changes
Mar 17, 2026
ewof
added a commit
to Mvndi/SiegeWar
that referenced
this pull request
Mar 18, 2026
…wnyAdvanced#1017) * max_active_siege_attacks_per_nation * Update src/main/java/com/gmail/goosius/siegewar/settings/SiegeWarSettings.java Co-authored-by: LlmDl <LlmDlio@gmail.com> * Update src/main/java/com/gmail/goosius/siegewar/settings/ConfigNodes.java Co-authored-by: LlmDl <LlmDlio@gmail.com> * Update src/main/java/com/gmail/goosius/siegewar/settings/ConfigNodes.java Co-authored-by: LlmDl <LlmDlio@gmail.com> --------- Co-authored-by: LlmDl <LlmDlio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
allow bigger nations to be able to siege more towns than smaller nations
New Nodes/Commands/ConfigOptions:
WAR_SIEGE_MAX_ACTIVE_SIEGE_ATTACKS_PER_NATION_USE_LEVELS
Relevant Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.