Create BattleSessionPenaltyPointsEvent#1001
Conversation
This event is designed to fire when a SiegeWarScoringUtil issues points for a players death (penalty points). Right now through SiegeWarAPI, you have to recreate the SiegeWarScoringUtil just to determine how many points were awarded for a players death. This simply little event lightens the load on addon developerss.
|
I think this is good, some of the naming is a bit confusing at first, but BattleSessionPenaltyPointsEvent is probably preferable to something longer like BattleSessionPlayerDeathPenaltyPointsEvent. One thing that might be worth adding is the location that the player died at, in case someone cares about that and wants the API for future use. Edit: I'll give this a day in case Goosius wants to review this. |
That is the third name I came up with and decided not to go with death because penalties can also be awarded for logging out, which is kinda like death but they only die after they log back in.
I didn't add this because I passed both player objects of the killer and victim which seem to have both possible locations of the event. |
|
Yeah the reason I'd add the location is because the player's location might
be changed if they respawn by the time the other plugin acts.
…On Mon, Jan 12, 2026, 3:57 PM GoodrichDev ***@***.***> wrote:
*GoodrichDev* left a comment (TownyAdvanced/SiegeWar#1001)
<#1001 (comment)>
I think this is good, some of the naming is a bit confusing at first, but
BattleSessionPenaltyPointsEvent is probably preferable to something longer
like BattleSessionPlayerDeathPenaltyPointsEvent.
That is the third name I came up with and decided not to go with death
because penalties can also be awarded for logging out, which is kinda like
death but they only die after they log back in.
One thing that might be worth adding is the location that the player died
at, in case someone cares about that and wants the API for future use.
I didn't add this because I passed both player objects of the killer and
victim which seem to have both possible locations of the event.
—
Reply to this email directly, view it on GitHub
<#1001 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGWZDASGERZ6GSMEHHBZ3T4GQKEXAVCNFSM6AAAAACRMYYQ2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONBQGY4DSMBWGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Description:
This event is designed to fire when a SiegeWarScoringUtil issues points for a players death (penalty points).
Right now through SiegeWarAPI, you have to recreate the SiegeWarScoringUtil just to determine how many points were awarded for a players death. This simply little event lightens the load on addon developers.
New Nodes/Commands/ConfigOptions:
New Event: BattleSessionPenaltyPointsEvent
Relevant Issue ticket:
None
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.