Skip to content

Siegewar thinks a siege is still happening even after it ended? #846

@blockutis

Description

@blockutis

Describe the bug
A siege was going on with a town, and then the attacker placed a white banner to surrender. After all 7 battle sessions had passed, in chat it said that the attacker had successfully abandoned it and that the town was saved.
The town's name no longer appears as a tab-complete option with the command /sw hud, however, if you still input the towns name yourself, using /sw hud TownName, it shows the hud for the siege, with the Siege Status being "Attacker Abandon", as shown here:
image

Also, when attempting to break the banner that was used to start the siege, it acts as if the banner is being used for a siege assembly:
image

To Reproduce

  1. Start a siege on a town.
  2. Wait 24h to be able to surrender the siege.
  3. Place the white banner to surrender.
  4. Wait until all 7 battle sessions have passed and the siege "ends"
  5. In chat it will say that the attacker has abandoned it and the town is saved.
  6. Try to break the banner, it doesn't let you, and says there is a siege assembly in progress.
  7. Try doing /sw hud TownName, and observe that the command still works, instead of saying "Town TownName does not have any active sieges" like it should.

Expected behavior
The siege should have ended, the banner should be breakable and the /sw hud command for that town should return "Town TownName does not have any active sieges".

Screenshots
/town Terra output:
image
Hovering over [Sieged]:
image

Versions (please complete the following information):

  • Towny: Version 0.99.1.0
  • SiegeWar: Version 2.5.1
  • Spigot/Paper: git-Paper-307 (MC: 1.19.2)

Files
Startup log: https://mclo.gs/AdKF2YB
SiegeWar config: https://pastebin.com/ZwcGfarA
Townyperms.yml: https://pastebin.com/WrfpFbvR

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions