i2c: rockchip: De-initialize the bus after start bit failure#194
i2c: rockchip: De-initialize the bus after start bit failure#194samueldr merged 1 commit intoTow-Boot:developmentfrom antoniprzybylik:i2cfix
Conversation
|
I've just tested it, it works. |
|
Hi there, just wondering how this was tested? I'm just curious haha |
|
I booted up the phone and it did not crash -- that's the test. |
|
How did you test that this patch does anything at all? Booting the device is one thing but testing if that actual patch does anything is another. I'm just curious. |
|
It's not my patch. It's taken from megi's u-boot -- https://xff.cz/git/u-boot/commit/?h=ppp&id=ccb804db1753958a33e7a6e55c52b3b04e4754e9 . I wrote to megi about proximity sensor not working, he directed me to the patch on his u-boot branch which fixes this issue. I thought I would also want to have this in tow-boot so I ported this patch to tow-boot -- #195 . But megi mentioned he has more bugs fixed in his u-boot branch so I ported also some other patches from his u-boot to tow-boot. I didn't do any elaborate tests -- I just made sure that tow-boot doesn't crash. Except for this proximity sensor -- it was better tested -- it actually starts to work after my patch. |
|
Awesome cool ty :) |
|
Hi, will look in the coming days/weeks. Just changed the target branch to Don't worry about the odd commits showing up from that, it'll all be fine in due time. |
|
github was being silly and wouldn't update the commit listing without forcing some event on the PR... |
|
Hi! Merging this soon, fixing the other batch of changes and will re-test combined. I force-pushed these changes:
BTW, some of it is on me: there's no contributor guide, no way for you to know how to name your commits :). |
Failure can happen when i2c is used without initializing pinctrl properly, which U-Boot happily allows. Without this fix, further I2C access would fail, even after proper pinctrl initialization. Signed-off-by: Antoni Przybylik <antoni.przybylik@wp.pl> Co-authored-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
|
Thank you for the contribution! |
Failure can happen when i2c is used without initializing pinctrl properly, which U-Boot happily allows. Without this fix, further I2C access would fail, even after proper pinctrl initialization.
This is based on megi's u-boot (see
https://xff.cz/git/u-boot/commit/?h=ppp&id=ccb804db1753958a33e7a6e55c52b3b04e4754e9)
It compiles, but I did not test it on real hardware yet.
Antoni Przybylik