Pinephone Pro: Set GPIO4_PD3 as input#195
Merged
samueldr merged 1 commit intoTow-Boot:developmentfrom Nov 8, 2022
antoniprzybylik:stk3311fix
Merged
Pinephone Pro: Set GPIO4_PD3 as input#195samueldr merged 1 commit intoTow-Boot:developmentfrom antoniprzybylik:stk3311fix
samueldr merged 1 commit intoTow-Boot:developmentfrom
antoniprzybylik:stk3311fix
Conversation
Contributor
|
github was being silly and wouldn't update the commit listing without forcing some event on the PR... |
Contributor
|
Force-pushed an inconsequential change, changing the prefix of the commit title to the board identifier. Will merged in a batch soon~ish, expect another force push to rebase when merging after testing. |
STK3311 driver expects this pin set as input. Signed-off-by: Antoni Przybylik <antoni.przybylik@wp.pl>
Contributor
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Copied from the other PR]
Good afternoon,
Setting GPIO4_PD3 as input is necessary for STK3311 sensor driver to function properly. That's what megi is doing in levinboot -- https://xff.cz/git/levinboot/commit/?id=6de55d9d4e991e9f261b4e323dfa8b0682cbe9e0
I did not have a chance to test it yet, will keep you informed about any progress on this.
I tested my previous patch. It didn't work, it didn't even compile. After that, however, I made some changes. You can see them in the history ("antoniprzybylik force-pushed the released branch from 318ce50 to bc7ccc2").
Now it works: It compiles. What's more, I tested it on real hardware, it works. What's more, the bug is fixed!!! STK3311 driver functions perfectly with my fixed tow-boot.
I changed name of this branch in my Tow-Boot repo from "released" to "stk3311fix". I had to open new pull request.
Previous (closed) pull request -- #193 .