pine64-pinephonePro: add smbios data#135
Merged
samueldr merged 1 commit intoTow-Boot:releasedfrom Jun 5, 2022
Merged
Conversation
3a266b6 to
35e1d0e
Compare
samueldr
reviewed
Mar 18, 2022
boards/pine64-pinephonePro/0001-rk3399-pinephone-pro-add-smbios-info.patch
Show resolved
Hide resolved
35e1d0e to
75f0511
Compare
Contributor
|
Hi! Sorry it took this long to finally look into this. It's because I really needed to investigate whether we could provide the data implicitly to any Tow-Boot builds. Turns out we can! But, good news, this PR is still valid and good!! The data should be part of the actual U-Boot source code, so this is a good example of how to do it correctly for a specific device. I still have to test this patch with #158 applied, but I have strong reasons to believe this is all good. |
Contributor
|
Oh curse me... It should have targeted development and not released. This is entirely my fault. (And GitHub's failure at providing good workflows...) |
samueldr
added a commit
that referenced
this pull request
Jun 5, 2022
Basically fixing my mistake when merging #135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds smbios data for the PinePhone Pro, tested on actual hardware with it running from SPI.
This should allow fwupd to function since it uses this data to generate unique device IDs