Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

Update index.ts - import net http and https using import * as#57

Merged
TooTallNate merged 1 commit into
TooTallNate:masterfrom
penseleit:patch-1
Jun 4, 2021
Merged

Update index.ts - import net http and https using import * as#57
TooTallNate merged 1 commit into
TooTallNate:masterfrom
penseleit:patch-1

Conversation

@penseleit

Copy link
Copy Markdown
Contributor

net, http, and https do not have any default exports.

This no default exports causes build errors for me.

net, http, and https do not have any default exports.
@TooTallNate TooTallNate merged commit 0288bc2 into TooTallNate:master Jun 4, 2021
@penseleit penseleit deleted the patch-1 branch June 4, 2021 02:12
umbrashia added a commit to umbrashia/node-socks-proxy-agent that referenced this pull request Jun 19, 2021
agent-base improve  statements in this pull request 

TooTallNate/node-agent-base#57

node_modules/agent-base/dist/src/index.d.ts:2:8 - error TS1192: Module '"net"' has no default export.

2 import net from 'net';
 
in Type-Script Version 4.2.3
Kikobeats added a commit to TooTallNate/node-socks-proxy-agent that referenced this pull request Jun 19, 2021
* error TS1192: Module '"net"' has no default export.

agent-base improve  statements in this pull request 

TooTallNate/node-agent-base#57

node_modules/agent-base/dist/src/index.d.ts:2:8 - error TS1192: Module '"net"' has no default export.

2 import net from 'net';
 
in Type-Script Version 4.2.3

* Update package.json

Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
@Apo-S

Apo-S commented Jun 21, 2021

Copy link
Copy Markdown

Will there be a new release with this fix? There is still an error in socks-proxy-agent@5.0.1 using yarn.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants