Conversation
f989ff0 to
51029a7
Compare
|
One issue is that the name could be a dark gray and then it would be hard to read. |
|
I'm not sure if it is something we need to address universally. We could have a preference to disable name colors in the sidebar. We already have this problem in the main chat window. I think it will generally be uncommon to see a black or dark gray name in Minecraft as it would be harder to read in game as well. |
| if (nameSpan) { | ||
| nameSpan.textContent = player.playerDisplayName; | ||
| nameSpan.replaceChildren( | ||
| formatChatMessage(player.playerDisplayName, {}), |
There was a problem hiding this comment.
formatChatMessage should probably get a new name. It's tough to pick a name because we have formatComponent already as an internal function name.
There was a problem hiding this comment.
formatMinecraftText I guess, or we just leave it because it mostly does chat messages anyway.
It is okay to say you simply don't like how my mockups look ;)
There is no reason why we couldn't apply it to all rendered minecraft text. But sure, nothing I am too hung up on. |
51029a7 to
4460faa
Compare
This reverts commit 54a6fe4.



Fixes: #143