Clicking on a username in the sidebar will activate the DM mode

This breaks current functionality where it fills in that persons name in the text area. Something I find myself do rather often.
I rather have that it only does so when clicking on the DM icon next to the name.

@creesch

I originally had it work that way but figured in the new state it was a bit confusing as to why clicking on the name didn't open DMs as in most other chat apps clicking on a username in a sidebar will open a DM with that user.

It seemed to me that the original functionality was born out of a lack of features (before tab-completion or DMing) and having the name filled in was better than nothing.

The way I look at it, as ideally most of the user-hours with this software are in the future, maintaining all existing functionality isn't as important as having the new state work well on its own. That being said, there's no way what I have implemented is the ideal. Do you have ideas for how to make this feature better?

For me it is a frequency of use thing, I am more likely to mention someone than starting a conversation with them. If I do dm them, it is more often a single message rather than me being locked in the conversation.

So I wouldn't expect clicking a user would do that. I also see your point that adding their name isn't necessarily the most logical thing either.

I am wondering if clicking someone's name should bring up a menu with options. But, given we have only two interactions I am not sure about that either.

To be clear it is just this aspect I am having some thoughts about. The rest of the implemented feature looks great to me!

Alright, has been long enough I probably should do something with this PR :P

Going to merge it for now. But there are two things we might want to adress in the future

• How to do tab complete on mobile now. Since that could be done throughthe menu.
• Might want to make it a bit more clearer visually that the user is in dm mode. It is visible now, but I am mostly thinking that maybe we do something with a slightly different input color border or something to make it stand out more.