-
Notifications
You must be signed in to change notification settings - Fork 614
feat: add Qwen3-VL and Qwen3-Max 0924 #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds new Qwen3 models (qwen3-max-2025-09-23, qwen3-vl-plus) to provider model settings, updates DashScope provider capability lists (enable_thinking/search), increases qwen3-max-preview maxTokens, and updates UI (ChatConfig, ModelConfigDialog) to support Qwen3 thinking budget (including min/max) and search visibility. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as Chat UI
participant Cfg as Model Settings
participant Prov as DashScopeProvider
participant API as DashScope API
User->>UI: Select Qwen3 model + set thinking/search
UI->>Cfg: Resolve model params (min/max budget, tokens)
Cfg-->>UI: {thinkingBudget, enable_search, vision...}
alt Qwen3 with thinking (e.g., qwen3-vl-plus)
UI->>Prov: send request (thinkingBudget <= 81920)
Prov->>API: chat.create(enable_thinking=true, budget)
API-->>Prov: response
else No thinking
UI->>Prov: send request (no thinking params)
Prov->>API: chat.create()
API-->>Prov: response
end
opt Search-enabled (e.g., qwen3-max-2025-09-23)
Prov->>API: enable_search=true
end
Prov-->>UI: message stream/result
UI-->>User: Render output
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.ts (1)
106-111: Don’t drop zero budgets: check against undefined, not truthyUsing a truthy check skips valid 0 values if we ever allow “disable” via 0 for DashScope models.
- if (modelConfig?.thinkingBudget) { + if (modelConfig?.thinkingBudget !== undefined) { modifiedParams.thinking_budget = modelConfig.thinkingBudget }
🧹 Nitpick comments (3)
src/renderer/src/components/settings/ModelConfigDialog.vue (2)
306-315: Use dynamic min from thinkingBudgetRange to avoid driftThe Qwen3 UI currently hard‑codes min=1 and displays min:1 in help text. Prefer the computed range for consistency with getThinkingBudgetConfig.
<Input v-model.number="config.thinkingBudget" type="number" - :min="1" + :min="thinkingBudgetRange.min" :max="thinkingBudgetRange.max" :step="128" :placeholder="t('settings.model.modelConfig.thinkingBudget.qwen3.placeholder')" :class="{ 'border-destructive': qwen3ThinkingBudgetError }" /> ... {{ t('settings.model.modelConfig.thinkingBudget.range', { - min: 1, + min: thinkingBudgetRange.min, max: thinkingBudgetRange.max }) }}Also applies to: 321-327
660-792: Normalize modelId in getThinkingBudgetConfig to lower‑caseSeveral includes checks assume lower‑case; normalizing prevents case‑sensitivity bugs.
// At the start of getThinkingBudgetConfig: const getThinkingBudgetConfig = (modelId: string) => { const id = modelId.toLowerCase() // Replace all `modelId.includes('...')` with `id.includes('...')` }src/renderer/src/components/ChatConfig.vue (1)
162-178: Avoid drift: derive supported model lists from a single sourceENABLE_SEARCH_MODELS is duplicated across provider, settings dialog, and here. Consider centralizing in shared constants or deriving from providerModelSettings.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/main/presenter/configPresenter/providerModelSettings.ts(2 hunks)src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.ts(2 hunks)src/renderer/src/components/ChatConfig.vue(7 hunks)src/renderer/src/components/settings/ModelConfigDialog.vue(3 hunks)
🧰 Additional context used
📓 Path-based instructions (23)
src/renderer/src/**/*
📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)
src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/**/*.{vue,ts,js,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
渲染进程代码放在
src/renderer
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/src/**/*.vue
📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)
Use scoped styles to prevent CSS conflicts between components
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/**/*.{vue,ts}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
Implement lazy loading for routes and components.
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/**/*.{ts,vue}
📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.Use Pinia for frontend state management (do not introduce alternative state libraries)
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use English for all logs and comments
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/renderer/src/components/ChatConfig.vuesrc/main/presenter/configPresenter/providerModelSettings.ts
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Enable and adhere to strict TypeScript typing (avoid implicit any, prefer precise types)
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/renderer/src/components/ChatConfig.vuesrc/main/presenter/configPresenter/providerModelSettings.ts
src/renderer/{src,shell,floating}/**/*.vue
📄 CodeRabbit inference engine (CLAUDE.md)
src/renderer/{src,shell,floating}/**/*.vue: Use Vue 3 Composition API for all components
All user-facing strings must use i18n keys via vue-i18n (no hard-coded UI strings)
Use Tailwind CSS utilities and ensure styles are scoped in Vue components
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/src/components/**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Organize UI components by feature within src/renderer/src/
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/src/**
📄 CodeRabbit inference engine (AGENTS.md)
Put application code for the Vue app under src/renderer/src (components, stores, views, i18n, lib)
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
src/renderer/src/**/*.{vue,ts}
📄 CodeRabbit inference engine (AGENTS.md)
All user-facing strings in the renderer must use vue-i18n keys defined in src/renderer/src/i18n
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
**/*.{js,jsx,ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
Apply Prettier formatting: single quotes, no semicolons, max width 100
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/renderer/src/components/ChatConfig.vuesrc/main/presenter/configPresenter/providerModelSettings.ts
src/renderer/**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
Name Vue components in PascalCase (e.g., ChatInput.vue)
Files:
src/renderer/src/components/settings/ModelConfigDialog.vuesrc/renderer/src/components/ChatConfig.vue
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development-setup.mdc)
**/*.{js,jsx,ts,tsx}: 使用 OxLint 进行代码检查
Log和注释使用英文书写
**/*.{js,jsx,ts,tsx}: Use OxLint for JS/TS code; pre-commit hooks run lint-staged and typecheck
Use camelCase for variables and functions
Use PascalCase for types and classes
Use SCREAMING_SNAKE_CASE for constants
Files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/main/presenter/configPresenter/providerModelSettings.ts
src/{main,renderer}/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/electron-best-practices.mdc)
src/{main,renderer}/**/*.ts: Use context isolation for improved security
Implement proper inter-process communication (IPC) patterns
Optimize application startup time with lazy loading
Implement proper error handling and logging for debugging
Files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/main/presenter/configPresenter/providerModelSettings.ts
src/main/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/electron-best-practices.mdc)
Use Electron's built-in APIs for file system and native dialogs
Files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/main/presenter/configPresenter/providerModelSettings.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-logging.mdc)
**/*.{ts,tsx}: 始终使用 try-catch 处理可能的错误
提供有意义的错误信息
记录详细的错误日志
优雅降级处理
日志应包含时间戳、日志级别、错误代码、错误描述、堆栈跟踪(如适用)、相关上下文信息
日志级别应包括 ERROR、WARN、INFO、DEBUG
不要吞掉错误
提供用户友好的错误信息
实现错误重试机制
避免记录敏感信息
使用结构化日志
设置适当的日志级别
Files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/main/presenter/configPresenter/providerModelSettings.ts
src/main/presenter/llmProviderPresenter/providers/*.ts
📄 CodeRabbit inference engine (.cursor/rules/llm-agent-loop.mdc)
src/main/presenter/llmProviderPresenter/providers/*.ts: Each file insrc/main/presenter/llmProviderPresenter/providers/*.tsshould handle interaction with a specific LLM API, including request/response formatting, tool definition conversion, native/non-native tool call management, and standardizing output streams to a common event format.
Provider implementations must use acoreStreammethod that yields standardized stream events to decouple the main loop from provider-specific details.
ThecoreStreammethod in each Provider must perform a single streaming API request per conversation round and must not contain multi-round tool call loop logic.
Provider files should implement helper methods such asformatMessages,convertToProviderTools,parseFunctionCalls, andprepareFunctionCallPromptas needed for provider-specific logic.
All provider implementations must parse provider-specific data chunks and yield standardized events for text, reasoning, tool calls, usage, errors, stop reasons, and image data.
When a provider does not support native function calling, it must prepare messages using prompt wrapping (e.g.,prepareFunctionCallPrompt) before making the API call.
When a provider supports native function calling, MCP tools must be converted to the provider's format (e.g., usingconvertToProviderTools) and included in the API request.
Provider implementations should aggregate and yield usage events as part of the standardized stream.
Provider implementations should yield image data events in the standardized format when applicable.
Provider implementations should yield reasoning events in the standardized format when applicable.
Provider implementations should yield tool call events (tool_call_start,tool_call_chunk,tool_call_end) in the standardized format.
Provider implementations should yield stop events with appropriatestop_reasonin the standardized format.
Provider implementations should yield error events in the standardized format...
Files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.ts
src/main/**/*.{ts,js,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
主进程代码放在
src/main
Files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/main/presenter/configPresenter/providerModelSettings.ts
src/main/**
📄 CodeRabbit inference engine (AGENTS.md)
Place all Electron main-process code under src/main/
Files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/main/presenter/configPresenter/providerModelSettings.ts
src/main/presenter/**
📄 CodeRabbit inference engine (AGENTS.md)
src/main/presenter/**: Organize main-process presenters under src/main/presenter/ (Window/Tab/Thread/Mcp/Config/LLMProvider)
Follow the Presenter pattern for main-process modules
Files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/main/presenter/configPresenter/providerModelSettings.ts
🧠 Learnings (2)
📚 Learning: 2025-09-06T03:07:23.817Z
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-06T03:07:23.817Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : New LLM providers must be added under src/main/presenter/llmProviderPresenter/providers/ as separate files
Applied to files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.ts
📚 Learning: 2025-09-06T03:07:23.817Z
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-06T03:07:23.817Z
Learning: Applies to src/main/presenter/configPresenter/providers.ts : Add provider configuration entries in src/main/presenter/configPresenter/providers.ts
Applied to files:
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.tssrc/main/presenter/configPresenter/providerModelSettings.ts
🔇 Additional comments (14)
src/renderer/src/components/settings/ModelConfigDialog.vue (3)
709-716: Qwen3 VL‑Plus thinking budget added — looks goodConfig aligns with other 81,920‑cap Qwen3 entries.
Please confirm VL‑Plus indeed requires min=1 (others often allow 0). If min should be model‑driven, see the next comment for a UI tweak to source min from the computed range.
834-843: Enable Qwen3 VL‑Plus thinking UI — OKVL‑Plus correctly added to supportedThinkingModels.
858-866: DashScope search support updated — OKqwen3-max-2025-09-23 correctly included.
src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.ts (2)
27-36: Add Qwen3 VL‑Plus to enable_thinking — OKMatches UI and provider settings.
40-52: Add qwen3‑max‑2025‑09‑23 to enable_search — OKConsistent with renderer/UI.
src/main/presenter/configPresenter/providerModelSettings.ts (3)
2750-2750: Increase qwen3‑max‑preview maxTokens to 65,536 — OKMatches upstream expectations.
2881-2891: Qwen3 VL‑Plus model added — OKVision=true, reasoning=true, 81,920 budget; match includes dated variant. Looks consistent with UI.
2733-2745: qwen3-max-2025-09-23 — repo references consistent; confirm external model IDModel ID appears in:
- src/main/presenter/configPresenter/providerModelSettings.ts
- src/main/presenter/llmProviderPresenter/providers/dashscopeProvider.ts
- src/renderer/src/components/ChatConfig.vue
- src/renderer/src/components/settings/ModelConfigDialog.vue
Config: enableSearch = true, maxTokens = 65536. Confirm this exact ID matches DashScope’s published model IDs.
src/renderer/src/components/ChatConfig.vue (6)
144-148: Include Qwen3 VL‑Plus in thinking‑capable models — OK
165-176: DashScope search models updated — OK
247-252: Add VL‑Plus to 81,920‑cap budget group — OK
268-272: Centralize Qwen3 min budget — OKHelper keeps UI consistent.
365-372: Validation now uses dynamic min — OKLeverages getQwen3MinBudget.
592-599: Reflect dynamic min/max in Qwen3 input and help — OKSwitched to getters; aligns UI and validation.
Also applies to: 606-611
* fix: katex style (#926) * refactor: reorganize artifact processing logic and improve attribute parsing (#927) * fix(thinkingBlock): pre style (#930) * refactor: remove DOMPurify dependency and replace MessageBlockThink `v-html` with vue-markdown-renderer (#931) * refactor: remove DOMPurify dependency and replace MessageBlockThink `v-html` with vue-markdown-renderer * chore: update * feat: add Qwen3-VL and Qwen3-Max 0924 (#932) * refactor: update vue-renderer-markdown to 0.0.54-beta.6 and remove Re… (#934) * refactor: update vue-renderer-markdown to 0.0.54-beta.6 and remove ReferenceNode component * chore: format * chore: version 0.3.7 --------- Co-authored-by: Simon He <57086651+Simon-He95@users.noreply.github.com> Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com>
add Qwen3-VL and Qwen3-Max
Summary by CodeRabbit
New Features
UI Improvements