feat: remove function deleteOllamaModel #1036

Dw9 · 2025-10-21T09:03:02Z

Removed the Ollama provider’s model deletion method

Summary by CodeRabbit

Bug Fixes
- Removed Ollama model deletion capability across the app: the delete confirmation dialog, related settings UI controls, and the deletion action are no longer available. Users can no longer delete Ollama models via the application; model management now excludes an in-app delete path.

coderabbitai · 2025-10-21T09:03:29Z

Walkthrough

The changes remove Ollama model deletion functionality across the presentation, provider, store, UI component, and type definition layers. No replacement logic is introduced; the delete method is eliminated consistently throughout the codebase.

Changes

Cohort / File(s)	Summary
Type Definitions `src/shared/types/presenters/legacy.presenters.d.ts`, `src/shared/types/presenters/llmprovider.presenter.d.ts`	Removed `deleteOllamaModel(modelName: string): Promise<boolean>` method signature from `ILlmProviderPresenter` interface.
Presenter & Provider Implementation `src/main/presenter/llmProviderPresenter/index.ts`, `src/main/presenter/llmProviderPresenter/providers/ollamaProvider.ts`	Removed `deleteOllamaModel` and `deleteModel` methods from `LLMProviderPresenter` and `OllamaProvider` classes respectively.
Store Layer `src/renderer/src/stores/settings.ts`	Removed `deleteOllamaModel(modelName: string)` method from `useSettingsStore`.
UI Component `src/renderer/settings/components/OllamaProviderSettingsDetail.vue`	Removed `:is-custom-model` prop and `@delete-model` event binding on `ModelConfigItem`, deleted delete confirmation dialog block, removed `showDeleteModelDialog` and `modelToDelete` state, removed `showDeleteModelConfirm` and `confirmDeleteModel` methods, removed `useToast` import and toast calls, removed `isModelRunning` helper.
Build Config `electron.vite.config.ts`	Added renderer build option `worker: { format: 'es' }` to emit worker scripts as ES modules.

Sequence Diagram(s)

sequenceDiagram
  participant UI as Renderer UI
  participant Store as useSettingsStore
  participant Presenter as LLMProviderPresenter
  participant Provider as OllamaProvider

  rect rgb(230, 250, 240)
    note right of UI: Previous flow (before this change)
    UI->>Store: dispatch deleteOllamaModel(modelName)
    Store->>Presenter: deleteOllamaModel(modelName)
    Presenter->>Provider: deleteModel(modelName)
    Provider-->>Presenter: success / failure
    Presenter-->>Store: result
    Store-->>UI: update & toast
  end

  rect rgb(250, 245, 235)
    note right of UI: New flow (after this change)
    UI--xStore: no deleteOllamaModel call (removed)
    Store--xPresenter: no deleteOllamaModel call
    Presenter--xProvider: no deleteModel call
    UI->>UI: local UI shows no delete action / dialog
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

feat: enable custom model config for Ollama provider #1018 — likely directly related: this PR removes Ollama deleteModel/deleteOllamaModel across layers and likely overlaps or reverts code introduced there.
fix: ensure renderer workers build as ES modules #1037 — related change to electron.vite.config.ts adding renderer.worker.format = 'es'.

Suggested labels

codex

Poem

🐰 I hopped through code with careful paws,

Snipped the delete for Ollama's cause.
No more dialogs, no more sighs,
Models stay where they reside.
A tidy burrow, neat and wise. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "feat: remove function deleteOllamaModel" directly and accurately describes the main change in the changeset. The primary focus of this PR is the comprehensive removal of the deleteOllamaModel capability across multiple layers of the codebase—including the presenter, provider, UI components, store, and type definitions. The title is concise, specific, and clearly communicates the primary change that a teammate scanning the history would immediately understand. While the changeset includes a minor unrelated configuration change to electron.vite.config.ts, the title appropriately focuses on the substantive change, which is standard practice since not every ancillary modification needs to be mentioned.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74cc4a8 and 2bda14b.

📒 Files selected for processing (1)

electron.vite.config.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

electron.vite.config.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build-check (x64)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

zerob13 · 2025-10-21T09:03:33Z

@codex review

chatgpt-codex-connector · 2025-10-21T09:05:31Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

* style(settings): format about page link handler (#1016) * style(ollama): format model config handlers (#1018) * fix: think content scroll issue (#1023) * fix: remove shimmer for think content * chore: update screen shot and fix scroll issue * chore: update markdown renderer * fix: import button bug and prevent backup overwriting during import (#1024) * fix(sync): fix import button bug and prevent backup overwriting during import * fix(sync): fix import button bug and prevent backup overwriting during import * fix(sync): fix import button bug and prevent backup overwriting during import * refactor(messageList): refactor message list ui components (#1026) * feat: remove new thread button, add clean button. * refactor(messageList): refactor message list ui components * feat: add configurable fields for chat settings - Introduced ConfigFieldHeader component for consistent field headers. - Added ConfigInputField, ConfigSelectField, ConfigSliderField, and ConfigSwitchField components for various input types. - Created types for field configurations in types.ts to standardize field definitions. - Implemented useChatConfigFields composable to manage field configurations dynamically. - Added useModelCapabilities and useModelTypeDetection composables for handling model-specific capabilities and requirements. - Developed useSearchConfig and useThinkingBudget composables for managing search and budget configurations. * feat: implement input history management in prompt input - Added `useInputHistory` composable for managing input history and navigation. - Implemented methods for setting, clearing, and confirming history placeholders. - Integrated arrow key navigation for browsing through input history. feat: enhance mention data handling in prompt input - Created `useMentionData` composable to aggregate mention data from selected files and MCP resources. - Implemented watchers to update mention data based on selected files, MCP resources, tools, and prompts. feat: manage prompt input configuration with store synchronization - Developed `usePromptInputConfig` composable for managing model configuration. - Implemented bidirectional sync between local config and chat store. - Added debounced watcher to reduce updates and improve performance. feat: streamline TipTap editor operations in prompt input - Introduced `usePromptInputEditor` composable for managing TipTap editor lifecycle and content transformation. - Implemented methods for handling mentions, pasting content, and clearing editor content. feat: handle file operations in prompt input - Created `usePromptInputFiles` composable for managing file selection, paste, and drag-drop operations. - Implemented methods for processing files, handling dropped files, and clearing selected files. feat: manage rate limit status in prompt input - Developed `useRateLimitStatus` composable for displaying and polling rate limit status. - Implemented methods for handling rate limit events and computing status icons, classes, and tooltips. * refactor(artifacts): migrate component logic to composables and update documentation - Refactor ArtifactDialog.vue to use composables for view mode, viewport size, code editor, and export functionality - Simplify HTMLArtifact.vue by removing drag-resize logic and using fixed viewport dimensions - Clean up MermaidArtifact.vue styling and structure - Update component refactoring guide to reflect new patterns and best practices - Adjust prompt input composable to allow delayed editor initialization - Update internationalization files for new responsive label * fix(lint): unused variables * fix(format): format code * CodeRabbit Generated Unit Tests: Add renderer unit tests for components and composables * feat: implement input history management in chat input component - Added `useInputHistory` composable for managing input history and placeholder navigation. - Implemented methods for setting, clearing, and confirming history placeholders. - Integrated arrow key navigation for cycling through input history. feat: enhance mention data handling in chat input - Created `useMentionData` composable to manage mention data aggregation. - Implemented watchers for selected files and MCP resources/tools/prompts to update mention data. feat: manage prompt input configuration and synchronization - Developed `usePromptInputConfig` composable for managing model configuration. - Implemented bidirectional sync between local config refs and chat store. - Added debounced watcher to reduce updates to the store. feat: manage prompt input editor operations - Introduced `usePromptInputEditor` composable for handling TipTap editor operations. - Implemented content transformation, mention insertion, and paste handling. - Added methods for handling editor updates and restoring focus. feat: handle prompt input files management - Created `usePromptInputFiles` composable for managing file operations in prompt input. - Implemented file selection, paste, drag-drop, and prompt files integration. feat: implement rate limit status management - Developed `useRateLimitStatus` composable for managing rate limit status display and polling. - Added methods for retrieving rate limit status icon, class, tooltip, and wait time formatting. * feat: enhance chat input component with context length management and settings integration * feat: update model configuration and enhance error handling in providers * feat: add MCP tools list component and integrate with chat settings feat: enhance artifact dialog with improved error handling and localization fix: update Mermaid artifact rendering error handling and localization fix: improve input settings error handling and state management fix: update drag and drop composable to handle drag events correctly fix: update Vitest configuration for better project structure and alias resolution * fix(i18n): add unknownError translation --------- Co-authored-by: deepinsect <deepinsect@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: add Poe provider integration and icon support (#1028) * feat: add Poe provider integration and icon support * chore: format and lint --------- Co-authored-by: zerob13 <zerob13@gmail.com> * fix: make auto scroll works (#1030) * fix: allow settings window links to open externally (#1029) * fix(settings): allow target blank links * fix: harden settings window link handling * feat: enhance GitHub Copilot Device Flow with OAuth token management and API token retrieval (#1021) * feat: enhance GitHub Copilot Device Flow with OAuth token management and API token retrieval - Fixed request header for managing OAuth tokens and retrieving API tokens. - Enhanced model definitions and added new models for better compatibility. * fix: remove privacy related log * fix: OAuth 2.0 for slow_down response * fix: handle lint errors * fix: provider fetched from publicdb * fix(githubCopilotProvider): update request body logging format for clarity * fix(githubCopilotProvider): improve error handling and logging in device flow * feat(theme): fix message paragraph gap and toolcall block (#1031) Co-authored-by: deepinsect <deepinsect@github.com> * fix: scroll to bottom (#1034) * fix: add debounce for renderer * feat: add max wait for renderer * chore(deps): upgrade markdown renderer add worker support * chore: bump markdown version * fix(build): use es module worker format (#1037) * feat: remove function deleteOllamaModel (#1036) * feat: remove function deleteOllamaModel * fix(build): use es module worker format (#1037) --------- Co-authored-by: duskzhen <zerob13@gmail.com> * perf: update dependencies to use stream-monaco and bump vue-renderer-markdown version (#1038) * feat(theme): add markdown layout style and table style (#1039) * feat(theme): add markdown layout style and table style * fix(lint): remove props --------- Co-authored-by: deepinsect <deepinsect@github.com> * feat: support effort and verbosity (#1040) * chore: bump up version * feat: add jiekou.ai as LLM provider (#1041) * feat: add jiekou.ai as LLM provider * fix: change api type to jiekou --------- Co-authored-by: zerob13 <zerob13@gmail.com> * chore: update provider db --------- Co-authored-by: 韦伟 <xweimvp@gmail.com> Co-authored-by: Happer <ericted8810us@gmail.com> Co-authored-by: deepinsect <deepinsect@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: cp90 <153345481+cp90-pixel@users.noreply.github.com> Co-authored-by: Cedric <14017092+douyixuan@users.noreply.github.com> Co-authored-by: Simon He <57086651+Simon-He95@users.noreply.github.com> Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com> Co-authored-by: cnJasonZ <gbdzxalbb@qq.com>

feat: remove function deleteOllamaModel

74cc4a8

fix(build): use es module worker format (ThinkInAIXYZ#1037)

2bda14b

zerob13 merged commit c796f1f into ThinkInAIXYZ:dev Oct 21, 2025
2 checks passed

Dw9 deleted the feat-remove-deleteOllama branch January 16, 2026 01:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: remove function deleteOllamaModel #1036

feat: remove function deleteOllamaModel #1036

Uh oh!

Dw9 commented Oct 21, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

zerob13 commented Oct 21, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: remove function deleteOllamaModel #1036

feat: remove function deleteOllamaModel #1036

Uh oh!

Conversation

Dw9 commented Oct 21, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Pre-merge checks and finishing touches

Uh oh!

zerob13 commented Oct 21, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dw9 commented Oct 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 21, 2025 •

edited

Loading