[FIX] Fix release 5.0.0 bad merge with 5.0.1#1690
[FIX] Fix release 5.0.0 bad merge with 5.0.1#1690CHaNGeTe merged 11 commits intoTheWidlarzGroup:masterfrom
Conversation
|
Closes #1688 |
|
@CHaNGeTe I would recommend adding some notes to the README about the AndroidX change in 5.x and what the implications are in terms of minimum supported React Native version and support (or not) for pre-AndroidX setups. Having that data available will help prevent people opening issues about it. |
|
@CHaNGeTe Oops looks like you just added it to the README, my bad for not checking the change list. Is it possible to use AndroidX with older React Native versions? |
|
@CHaNGeTe , i will try to check it in the end of today, now i am in the office. i can't check it. sorry about that. ( now it is the morning in Viet Nam ) |
|
@cobarx I think you need react-native >=0.60 for that. And >=0.59.1 for 64bit builds. |
|
Can this be merged? 😇 |
| @@ -18,3 +18,5 @@ | |||
| # org.gradle.parallel=true | |||
|
|
|||
| android.useDeprecatedNdk=true | |||
There was a problem hiding this comment.
I believe android.useDeprecatedNdk is no longer supported?
There was a problem hiding this comment.
should I remove the property then?
|
@CHaNGeTe sorry I've been offline for a bit. Looks fine to merge. |
| ... | ||
| compile project(':react-native-video') | ||
| implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}" | ||
| + implementation "androidx.appcompat:appcompat:1.0.0" |
There was a problem hiding this comment.
the latest version is 1.0.2
androidx.appcompat:appcompat:1.0.2
|
|
||
| android.useDeprecatedNdk=true | ||
| android.useAndroidX=true | ||
| android.enableJetifier=true No newline at end of file |
|
Sorry to bother, I was just wondering is there any ETA for this? |
|
released |
…rry-pick [FIX] Fix release 5.0.0 bad merge with 5.0.1 (rebased from commit d858bf7)
A bad merging process occurred on release 5.0.0 (AndroidX support)
This tries to fix it.
@vokhuyetOz can you also check this PR? sorry for that