Conversation
BenjaminBrienen
approved these changes
Oct 10, 2024
Member
Author
|
Thanks for the reviews! |
BD103
added a commit
that referenced
this pull request
Oct 11, 2024
TimJentzsch
added a commit
that referenced
this pull request
Oct 16, 2024
Closes #134. This PR adjusts the default `index.html` we serve with `bevy run web` to work better for a Bevy app that doesn't have any special configuration. We don't assume anymore that the canvas is already created with ID `#bevy`, but instead watch for a new canvas to be created (which is the default behavior). We also adjust the styling to better work with this setup and change the web background color to the default Bevy app background color. --------- Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustchas a series of internal lints that checks that its own APIs are being used correctly. Since we are using privaterustccrates, we should enable these lints to avoid footguns.I first learned about this lint group when browsing Clippy's source code. Funnily enough,
rustc -W helpdoesn't printinternalas a possible group, which is why I didn't know about it earlier.