Skip to content

diagnose: loud tool-execution dispatch + return WARNs (closes #130)#131

Merged
PowerCreek merged 1 commit into
mainfrom
loud-tool-execution-diagnostic
May 27, 2026
Merged

diagnose: loud tool-execution dispatch + return WARNs (closes #130)#131
PowerCreek merged 1 commit into
mainfrom
loud-tool-execution-diagnostic

Conversation

@PowerCreek

Copy link
Copy Markdown

Closes #130. v0.18.5 confirmed write_file IS in valid_tool_names, but the side-effect STILL doesn't materialize. Operators have no signal between dispatch entry and handler return — can't isolate guardrail-block / sandbox-routing / silent handler error. This PR adds WARN logs at entry + post-handler per-tool with result-preview, _execution_blocked flag, duration. Pure observability. 3 source-level tests, 6 total green.

v0.18.5 confirmed invalid_tool_call WARN does NOT fire on sandbox —
so write_file IS in agent.valid_tool_names. Side-effect STILL
doesn't materialize. Operators have no signal between (a)
dispatch entry, (b) handler invocation, (c) handler return; can't
tell guardrail-block from sandbox-routing from silent handler
error.

## Fix

Pure observability — no behavior change. Two WARN logs in
``agent/tool_executor.py::execute_tool_calls_sequential``:

1. **Entry**: ``dispatching N tool_call(s) [names] (task_id=X
   api_call=N model=M provider=P)`` — one log per dispatch call.
   Confirms hermes IS routing to the executor.

2. **Post-handler per-tool**: ``tool_call dispatched: name=X
   task_id=X blocked=BOOL duration=Ns result_preview='...'`` —
   captures the handler's actual return string (180-char
   truncate) + the ``_execution_blocked`` flag. Surfaces:
   * Guardrail / pre-hook block (``blocked=True``)
   * Handler-ran-but-errored (preview shows error message)
   * Handler-ran-routed-elsewhere (preview shows sandbox-internal
     path / write-id)
   * Handler-ran-cleanly (preview shows expected return shape)

Positioned AFTER the if/elif/elif/else convergence so all 4
dispatch branches (spinner-quiet, memory-provider, plain-quiet,
non-quiet) hit the same diagnostic.

## Tests

- 3 source-level tests in
  tests/agent/test_loud_tool_execution_diagnostic.py:
  entry-diagnostic patch landed, per-tool result-preview patch
  landed, entry diagnostic fires exactly once per invocation
  (not per-branch).
- 6 total green across the diagnostic family.

## Composition

After this lands the operator should see the actual handler
return for ``write_file``. The next bug isolation step depends
on what the preview reveals.
@PowerCreek PowerCreek merged commit f5cd1e2 into main May 27, 2026
@PowerCreek PowerCreek deleted the loud-tool-execution-diagnostic branch May 27, 2026 04:47
PowerCreek added a commit that referenced this pull request May 28, 2026
…143) (#145)

T3 of the #143 thin-client refactor scope. When the active provider
is ``devagentic-local``, augment ``disabled_toolsets`` with
``"clarify"`` before the ``get_tool_definitions`` call.

## Rationale

Per devagentic#203 §1.3 + the #143 scope: devagentic-side intent
classifier knows when clarification is actually needed and can
surface it via an OpenAI-shaped assistant message. Hermes' modal
TUI clarify-tool was a layered opinion fighting devagentic-side
classification — both rotation's debug evidence + sandbox UX
showed the dual-source as confusing (clarify modal popped even
with --yolo, ignoring devagentic-side intent signals).

This is the smallest of the T1-T3 sequence and the cleanest
revert path — purely a tool-registry adjustment for one provider.

## Behavior

| Setting | Before | After |
|---|---|---|
| provider=devagentic-local, no --enable-toolset | clarify enabled | clarify implicitly disabled |
| provider=devagentic-local, --enable-toolset clarify | clarify enabled | clarify enabled (explicit override) |
| provider=other | unchanged | unchanged |

A boot-line print informs operators of the implicit disable + how
to re-enable for legacy workflows. Composes naturally with the
existing ``HERMES_TOOLS_SUBSET`` narrowing (#75/#87) — disable
happens first, then subset narrows further if set.

## Tests

- 4 source-level tests in
  ``tests/agent/test_t3_clarify_default_out.py``: patch-landed,
  explicit-enable-overrides-implicit-disable, re-enable hint
  visible in print message, strict-equality on provider name
  (no prefix/alias matching to avoid surprise on related
  providers).
- 21 total green across affected suites (T3 + diag-env-gate).

## Composition

Per #143 sequencing (T3 → T1 → T2-gated → T2-default-flip):
- This PR: T3 (clarify default-out)
- Next: T1 (HERMES_DEFER_PERSONA default-flip for devagentic-local)
- Then: T2 (empty-content recovery removal, env-gated then default)
- Later: T4-T6 (tool list / iteration cap / summary fallback)

## Preserved through the refactor

- PR #119 (cascade_exhausted short-circuit) — hermes correctly
  deferring to devagentic; NOT recovery
- PR #122/#125 (raw tool_calls fallback) — pre-recovery wire
  parsing; belt-and-suspenders against future streaming-chunker
  regressions
- PR #131/#136/#138/#141 diagnostics — env-gated via
  HERMES_DIAG_RAW_CAPTURE; no-op when off
PowerCreek added a commit that referenced this pull request May 28, 2026
…MPTY_RECOVERY (refs #143) (#147)

T2 of the #143 thin-client refactor scope. Devagentic-side cascade
(NousResearch#324) + runaway detector (NousResearch#345-348) + exec-terminus (NousResearch#349-354)
now cover the empty-content recovery layer with full intent /
role / dispatch-trace context. Hermes-side recovery layered on top
caused 3×4 dispatch stacking (#118) + mode confusion + invisible
swallow points (#133 debug funnel).

This patch default-flips: the four hermes-side recovery paths are
short-circuited unless ``HERMES_LEGACY_EMPTY_RECOVERY`` is set to
a truthy value. Legacy users opt-in to keep the pre-T2 behavior.

## Gated paths (all skipped when env unset)

| Path | Source | Loc |
|---|---|---|
| ``_finish_wants_tools`` synthetic recovery | PR #108 / #99 | line ~3618 |
| ``_post_tool_empty_retried`` nudge | pre-existing NousResearch#9400-class | line ~3749 |
| ``_structural_empty`` synthetic recovery | PR #69 / #67 | line ~3880 |
| 3-retry empty-content loop | pre-#67 | line ~3927 |

When env unset (default), empty responses fall through to either
the fallback-chain provider switch (if configured) or the clean
``(empty)`` terminal with ``_empty_terminal_sentinel=True``.

## Preserved through T2 (verified by test_t2_legacy_empty_recovery_gate.py)

- **PR #119 cascade_exhausted short-circuit** — hermes correctly
  deferring to devagentic's sentinel; NOT recovery. Source-level
  test asserts the ``if _cascade_err:`` block is NOT prefixed by
  ``_legacy_recovery_on``.
- **PR #122/#125 raw tool_calls fallback** — pre-recovery wire
  parsing in transports/chat_completions.py. Source-level test
  asserts the helper name doesn't appear in conversation_loop
  (lives elsewhere; untouched).
- **PR #131/#136/#138/#141 diagnostics** — env-gated via
  ``HERMES_DIAG_RAW_CAPTURE`` (#140), independent of this env.

## Operator deploy

Default behavior changes: empty responses surface cleanly (no
synthetic re-prompt). To preserve pre-T2 behavior:

```bash
export HERMES_LEGACY_EMPTY_RECOVERY=1
```

The legacy escape hatch is intended as a temporary safety net
while operators validate the thin-client architecture. Once the
devagentic-side cascade is universally deployed + observed to
cover all empty-content cases, the legacy gate can be removed in
a follow-up (the env var stays as a no-op for backward compat).

## Tests

- 23 new tests in
  ``tests/agent/test_t2_legacy_empty_recovery_gate.py``:
  resolver default-false / empty-false / 6 truthy / 6 falsy-or-
  unknown; source-level gate assertions for each of the four
  recovery branches; preserved-path assertions for cascade_exhausted
  + raw tool_calls fallback location; default-off + opt-in
  resolver round-trip.
- 163 total green across affected suites (T2 + existing empty-
  terminal mirror tests + finish_reason_tools_recovery +
  cascade_exhausted + internal_marker_stripping +
  tool_call_type_default + tool_use_enforcement + T3 + T1 persona
  + doctor persona probe).

## Composition

Per #143 sequencing:
- T3 / PR #145 (clarify default-out) — merged ✓
- T1 / PR #146 (persona default-flip) — merged ✓
- **T2 / this PR (empty-content recovery removal, env-gated)**
- Later: T4-T6 (tool list / iteration cap / summary fallback)

The legacy escape hatch design choice (vs. full removal) lets
operators roll back per-deployment if a previously-recovered edge
case surfaces in the field. Diagnostic from #140
(HERMES_DIAG_RAW_CAPTURE) remains the observability tool to spot
any uncovered case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

diagnose: tool_calls dispatched but side-effect doesn't fire — need entry/return WARNs in tool_executor

1 participant