Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit a878fce
☁️ Nx Cloud last updated this comment at |
| /** | ||
| * @deprecated use createRouter's `scrollRestoration` option instead | ||
| */ | ||
| export function ScrollRestoration(_props: ScrollRestorationOptions) { |
There was a problem hiding this comment.
Do we need to provide this component?
There was a problem hiding this comment.
React/Solid has this - why would specifically vue-router not need this component?
Since a Vue single-file component (SFC) only can export one component, and most tanstack router routes export multiple (main component, error compoentn, not found component etc.) the iteration here uses either JSX or multiple vue files like this:
File-Based Routing Conventions
optional vue-specific route files
.component.vue.errorComponent.vue.notFoundComponent.vue.pendingComponent.vueexisting
.ts.lazy.ts_layoutprefix_suffix (e.g.,posts_.$postId)(groupName)directory$param