chore(eslint): resolve eslint errors in hydrateStart by nlynzaad · Pull Request #5521 · TanStack/router

nlynzaad · 2025-10-17T22:12:43Z

Summary by CodeRabbit

Refactor
- Reorganized internal code structure for improved maintainability.

Note: This release contains internal improvements with no user-facing changes.

nx-cloud · 2025-10-17T22:13:15Z

View your CI Pipeline Execution ↗ for commit 8bb8921

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	5m 19s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	28s	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-17 22:19:02 UTC

coderabbitai · 2025-10-17T22:13:21Z

Walkthrough

Import declarations were reordered in hydrateStart.ts by moving top-level imports for startInstance and getRouter earlier in the file, removing their inline imports later. No functional behavior, control flow, or public API changes were introduced.

Changes

Cohort / File(s)	Summary
Import Reorganization `packages/start-client-core/src/client/hydrateStart.ts`	Moved `startInstance` and `getRouter` imports to top-level with ESLint disable comments; removed corresponding inline imports. No logic or behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop and a shuffle, imports align,
No logic was changed, just organized fine,
The code flows the same, with style more refined,
What once was nested, now's easy to find! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "chore(eslint): resolve eslint errors in hydrateStart" accurately reflects the main purpose of the pull request. The changes show that ESLint disable comments were moved alongside import reordering in the hydrateStart.ts file, which aligns directly with the title's intent to resolve ESLint errors. The title is concise, uses proper semantic commit type (chore), and clearly specifies both the issue category (eslint) and the affected file (hydrateStart), making it easy for teammates to understand the PR's purpose when scanning history.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch hydrateStart-eslint

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2025-10-17T22:14:47Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5521

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5521

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5521

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5521

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5521

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5521

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5521

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5521

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5521

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5521

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5521

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5521

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5521

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5521

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5521

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5521

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5521

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5521

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5521

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5521

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5521

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5521

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5521

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5521

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5521

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5521

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5521

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5521

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5521

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5521

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5521

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5521

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5521

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5521

commit: 8bb8921

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf4f3e6 and 8bb8921.

📒 Files selected for processing (1)

packages/start-client-core/src/client/hydrateStart.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript in strict mode with extensive type safety across the codebase

Files:

packages/start-client-core/src/client/hydrateStart.ts

packages/{*-start,start-*}/**

📄 CodeRabbit inference engine (AGENTS.md)

Name and place Start framework packages under packages/-start/ or packages/start-/

Files:

packages/start-client-core/src/client/hydrateStart.ts

🪛 ESLint

packages/start-client-core/src/client/hydrateStart.ts

[error] 4-4: #tanstack-start-entry import should occur after type import of @tanstack/router-core

(import/order)

[error] 6-6: #tanstack-router-entry import should occur after type import of @tanstack/router-core

(import/order)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Test
GitHub Check: Preview

packages/start-client-core/src/client/hydrateStart.ts

resolve eslint errors

resolve eslint errors

8bb8921

github-actions bot added the package: start-client-core label Oct 17, 2025

coderabbitai bot reviewed Oct 17, 2025

View reviewed changes

packages/start-client-core/src/client/hydrateStart.ts Show resolved Hide resolved

nlynzaad merged commit 4f9b737 into main Oct 17, 2025
6 checks passed

nlynzaad deleted the hydrateStart-eslint branch October 17, 2025 22:24

This was referenced Oct 19, 2025

Solid hydration #5518

Merged

move hydrate call inside shared packages #5565

Closed

fix: solid start error outside monorepo #5566

Merged

coderabbitai bot mentioned this pull request Nov 2, 2025

chore(start-client-core): disable import-order rule for #tanstack imports #5732

Merged

naoya7076 pushed a commit to naoya7076/router that referenced this pull request Feb 15, 2026

chore(eslint): resolve eslint errors in hydrateStart (TanStack#5521)

5c974a1

resolve eslint errors

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(eslint): resolve eslint errors in hydrateStart#5521

chore(eslint): resolve eslint errors in hydrateStart#5521
nlynzaad merged 1 commit intomainfrom
hydrateStart-eslint

nlynzaad commented Oct 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

nx-cloud bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 17, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

nlynzaad commented Oct 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

nx-cloud bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

pkg-pr-new bot commented Oct 17, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nlynzaad commented Oct 17, 2025 •

edited by coderabbitai bot

Loading

nx-cloud bot commented Oct 17, 2025 •

edited

Loading

coderabbitai bot commented Oct 17, 2025 •

edited

Loading