chore: update eslint-plugin-vue by lachlancollins · Pull Request #9691 · TanStack/query

lachlancollins · 2025-09-26T10:17:30Z

🎯 Changes

Reduces install size and adds some missing type declarations.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated the Vue ESLint plugin to the latest major version across packages.
- Aligned ESLint configuration and removed suppression directives.
- No impact to runtime behavior, public APIs, or end-user functionality.

changeset-bot · 2025-09-26T10:17:34Z

⚠️ No Changeset found

Latest commit: 1709f2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-09-26T10:17:37Z

Walkthrough

Updated eslint-plugin-vue devDependency to ^10.5.0 in two packages and removed TypeScript error-suppression comments around plugin imports in corresponding ESLint configs. No changes to runtime code, exports, scripts, or public APIs.

Changes

Cohort / File(s)	Summary of changes
ESLint config import cleanup `packages/vue-query-devtools/eslint.config.js`, `packages/vue-query/eslint.config.js`	Removed ts-expect-error suppression around importing eslint-plugin-vue; retained existing export merging with pluginVue.configs.
Dev dependency bump: eslint-plugin-vue `packages/vue-query-devtools/package.json`, `packages/vue-query/package.json`	Updated devDependency eslint-plugin-vue from ^9.27.0 to ^10.5.0. No other package.json changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

package: vue-query-devtools, package: vue-query

Poem

A bunny taps keys with a linty cheer,
Hops to Vue rules, fresh and clear.
Errors unsuppressed, the paths are true,
Devtools and query both renew.
Carrots aligned, configs in tune—
Ship it swift, by the light of the moon. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The description follows the required template structure but its Changes section inaccurately summarizes the modifications—it omits the eslint-plugin-vue version bump and removal of ts-expect-error directives in favor of reducing install size and adding declarations—and the local testing checklist remains unchecked.	Revise the Changes section to accurately describe the eslint-plugin-vue upgrade and removal of TypeScript error suppressions, and complete or confirm the pnpm test:pr checklist item once tests have been run successfully.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly describes the primary change of updating the eslint-plugin-vue dependency and aligns with the main modifications made in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch update-eslint-plugin-vue

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b40dd9 and 1709f2a.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (4)

packages/vue-query-devtools/eslint.config.js (0 hunks)
packages/vue-query-devtools/package.json (1 hunks)
packages/vue-query/eslint.config.js (0 hunks)
packages/vue-query/package.json (1 hunks)

💤 Files with no reviewable changes (2)

packages/vue-query-devtools/eslint.config.js
packages/vue-query/eslint.config.js

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-09-02T17:57:33.184Z

Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.

Applied to files:

packages/vue-query-devtools/package.json
packages/vue-query/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Test
GitHub Check: Preview

🔇 Additional comments (2)

packages/vue-query-devtools/package.json (1)

58-58: Same eslint-plugin-vue v10 check applies here

Once the workspace-wide ESLint version check from the previous comment is green, this devtools package is covered too—no additional changes needed beyond verifying compatibility.

packages/vue-query/package.json (1)

73-73: No ESLint version bump required Workspace ESLint (^9.36.0) satisfies eslint-plugin-vue@10’s peer requirement (eslint ^8.57.0 || ^9.0.0). Confirm pnpm test:eslint still passes.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-09-26T10:18:17Z

View your CI Pipeline Execution ↗ for commit 1709f2a

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 15s	View ↗

☁️ Nx Cloud last updated this comment at 2025-09-26 12:01:09 UTC

pkg-pr-new · 2025-09-26T10:20:19Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9691

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9691

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9691

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9691

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9691

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9691

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9691

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9691

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9691

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9691

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9691

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9691

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9691

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9691

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9691

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9691

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9691

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9691

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9691

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9691

commit: 1709f2a

github-actions · 2025-09-26T10:20:20Z

Sizes for commit 1709f2a:

Branch	Bundle Size
Main
This PR

codecov · 2025-09-26T12:01:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.38%. Comparing base (4b40dd9) to head (1709f2a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9691   +/-   ##
=======================================
  Coverage   46.38%   46.38%           
=======================================
  Files         214      214           
  Lines        8488     8488           
  Branches     1919     1927    +8     
=======================================
  Hits         3937     3937           
  Misses       4108     4108           
  Partials      443      443

Components	Coverage Δ
@tanstack/angular-query-experimental	`93.85% <ø> (ø)`
@tanstack/eslint-plugin-query	`83.24% <ø> (ø)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`24.39% <ø> (ø)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`97.48% <ø> (ø)`
@tanstack/query-devtools	`3.48% <ø> (ø)`
@tanstack/query-persist-client-core	`79.60% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/query-test-utils	`77.77% <ø> (ø)`
@tanstack/react-query	`96.00% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.06% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`87.58% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.10% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chore: update eslint-plugin-vue

1709f2a

github-actions bot added package: vue-query package: vue-query-devtools labels Sep 26, 2025

lachlancollins merged commit db60bdd into main Sep 26, 2025
9 of 10 checks passed

lachlancollins deleted the update-eslint-plugin-vue branch September 26, 2025 12:02

Hellol77 pushed a commit to Hellol77/query that referenced this pull request Oct 14, 2025

chore: update eslint-plugin-vue (TanStack#9691)

990c7ee

coderabbitai bot mentioned this pull request Oct 23, 2025

chore(deps): update all non-major dependencies #9784

Closed

1 task

coderabbitai bot mentioned this pull request Nov 25, 2025

chore(deps): update all non-major dependencies #9881

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: update eslint-plugin-vue#9691

chore: update eslint-plugin-vue#9691
lachlancollins merged 1 commit intomainfrom
update-eslint-plugin-vue

lachlancollins commented Sep 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Sep 26, 2025

Uh oh!

coderabbitai bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

codecov bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

lachlancollins commented Sep 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Pre-merge checks and finishing touches

Uh oh!

nx-cloud bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

codecov bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lachlancollins commented Sep 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 26, 2025 •

edited

Loading

nx-cloud bot commented Sep 26, 2025 •

edited

Loading

codecov bot commented Sep 26, 2025 •

edited

Loading