feat(eslint-plugin-query): Add compatibility with flat config#7663
Merged
lachlancollins merged 9 commits intomainfrom Jul 3, 2024
Merged
feat(eslint-plugin-query): Add compatibility with flat config#7663lachlancollins merged 9 commits intomainfrom
lachlancollins merged 9 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6928cb8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6928cb8:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7663 +/- ##
=========================================
+ Coverage 0 44.46% +44.46%
=========================================
Files 0 185 +185
Lines 0 7049 +7049
Branches 0 1547 +1547
=========================================
+ Hits 0 3134 +3134
- Misses 0 3552 +3552
- Partials 0 363 +363 |
39 tasks
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Aug 27, 2024
… @ `stores/relativeTime` * switch to flat config as `@tanstack/eslint-plugin-query`: TanStack/query#7663, `eslint-plugin-pinia`: lisilinhart/eslint-plugin-pinia#35 & `eslint-plugin-import-x`: un-ts/eslint-plugin-import-x#122 now supports it @ eslint.config.js @ fe
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Aug 27, 2024
… @ `stores/relativeTime` * switch to flat config as `@tanstack/eslint-plugin-query`: TanStack/query#7663, `eslint-plugin-pinia`: lisilinhart/eslint-plugin-pinia#35 & `eslint-plugin-import-x`: un-ts/eslint-plugin-import-x#122 now supports it @ eslint.config.js @ fe
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Aug 27, 2024
… @ `stores/relativeTime` * switch to flat config as `@tanstack/eslint-plugin-query`: TanStack/query#7663, `eslint-plugin-pinia`: lisilinhart/eslint-plugin-pinia#35 & `eslint-plugin-import-x`: un-ts/eslint-plugin-import-x#122 now supports it @ eslint.config.js @ fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a recommended preset for flat config is a bit messy, as it needs to import the plugin itself. The ESLint docs show how to work around this here.
For some reason, ATTW generates a
false-export-defaultwarning. Since we distribute separate CJS and ESM source and types, this problem is avoided.