feat: allow custom merge function for structuralSharing#3868
Merged
TkDodo merged 1 commit intoTanStack:mainfrom Aug 16, 2022
Merged
feat: allow custom merge function for structuralSharing#3868TkDodo merged 1 commit intoTanStack:mainfrom
TkDodo merged 1 commit intoTanStack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb3fcb3:
|
richsilv
commented
Jul 19, 2022
80c7b8b to
fb3fcb3
Compare
Codecov Report
@@ Coverage Diff @@
## main #3868 +/- ##
==========================================
+ Coverage 96.36% 96.81% +0.45%
==========================================
Files 45 57 +12
Lines 2281 2668 +387
Branches 640 783 +143
==========================================
+ Hits 2198 2583 +385
- Misses 80 83 +3
+ Partials 3 2 -1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TkDodo
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here and here, this allows the provision of a function as the
structuralSharingvalue, which effectively acts as a replacement forreplaceEqualDeep. This way, consumers can still achieve the performance benefits of retained references even when cache data contains non-serializable values.