fix: separate about screen title from translations #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csponge
pushed a commit
to csponge/TagStudio
that referenced
this pull request
Mar 10, 2025
* fix: separate about screen title from translations * chore: format with ruff's evil twin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a visual glitch in the "About" screen where empty parentheses were present due to being hardcoded inside the translation files. The title has now been separated out and uses the same method as the window title to dynamically add subtitle parentheses if needed. Some other minor UI tweaks were made as well, notably using the build-in UI color palette for consistency.
The Bug:
Tasks Completed