Postpone instantiating modal windows #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
reviewed
Sep 1, 2024
Member
CyanVoxel
left a comment
There was a problem hiding this comment.
Thank you for this! The UI initialization has been ripe for optimizations like this.
When testing the UniversalDetector however, I noticed that it appears to not play well with the multithreaded nature of ThumbRenderer. When running successive tests on a folder full of differently encoded text files, I was able to get it to consistently mix up the encodings producing a different spotty mix of unrendered thumbnails each time.
014620d to
05b4168
Compare
Contributor
Author
|
I reverted the last commit with |
CarterPillow
pushed a commit
to CarterPillow/TagStudio
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
easy backport from #332 which could be actually nice for the upcoming release
- also reuseUniversalDetectorinstance for files encoding detection.