Fixed memory leak in ArchRule.AssertionError in combination with JUnit 4#123
Merged
Conversation
…es keep reference to the respective AssertionError, ArchRule.AssertionError kept reference to EvaluationResult, thus making it impossible to GC big results over the whole JUnit run. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
ec61b97 to
8b859a4
Compare
codecholeric
added a commit
that referenced
this pull request
Feb 21, 2021
Fixed memory leak in ArchRule.AssertionError in combination with JUnit 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chain JUnit 4 Core -> Failure -> ArchRule.AssertionError -> EvaluationResult causes (sometimes huge) EvaluationResults to be hard-referenced through the whole JUnit run, which was never intended (original design error due to the assumption, that an AssertionError would be something transient).
This PR removes ArchRule.AssertionError (causing a breaking change)