Merged
Conversation
…etch_and_cache methods
- Updated JSON schemas for desktop and macOS to include new permissions: `allow-register-listener`, `allow-remove-listener`, `deny-register-listener`, and `deny-remove-listener`. - Improved `EventSinkManager` to prevent redundant sink starts and added a delay for sink initialization. - Refactored logging nodes (ErrorNode, InfoNode, WarningNode) to handle messages as generic values instead of strings, allowing for better flexibility in logging. - Enhanced execution context and internal node handling to support context pin overrides, improving the evaluation of pin values. - Cleaned up HTTP client caching logic for better readability.
…sections for improved user guidance
…projects used in Flow-Like
refactor: update ExecutionContext to simplify pin value overrides refactor: enhance logging nodes with on_update method for message matching
…lue methods for improved isolation in parallel execution
Closed
6 tasks
This was referenced Oct 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important updates to the desktop application's event sink and deep link handling. The main focus is on renaming the "path" field to "route" for deep links, ensuring database and code consistency, and improving schema permissions. Additionally, there are enhancements to the event sink manager's concurrency handling and error reporting.
Deeplink and Event Sink Refactoring:
Renamed all instances of the deep link field from
pathtoroutethroughout the codebase, including the database schema, Rust structs, and TypeScript event config. This includes updating table columns, SQL queries, log messages, and struct field names. A migration function ensures legacy databases are updated frompathtoroute. (apps/desktop/src-tauri/src/event_sink/deeplink.rs,apps/desktop/src-tauri/src/deeplink.rs,apps/desktop/lib/event-config.ts) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Added a migration step to rename the legacy
pathcolumn toroutein thedeeplink_routestable and to update related indexes, ensuring backward compatibility for existing users. (apps/desktop/src-tauri/src/event_sink/deeplink.rs)Schema and Permissions Updates:
desktop-schema.jsonandmacOS-schema.jsonto includeallow-register-listenerandallow-remove-listener. Also added explicit allow/deny entries for these permissions, improving granularity and clarity for plugin developers. (apps/desktop/src-tauri/gen/schemas/desktop-schema.json,apps/desktop/src-tauri/gen/schemas/macOS-schema.json) [1] [2] [3]Event Sink Manager Improvements:
Implemented a
Clonetrait forEventSinkManagerto support safe concurrent usage. (apps/desktop/src-tauri/src/event_sink/manager.rs)Improved concurrency and error handling in the
start_sink_oncemethod: now ensures only one instance of a sink is started at a time, and if startup fails, the sink is properly removed from the started set. (apps/desktop/src-tauri/src/event_sink/manager.rs)These changes collectively improve the maintainability, safety, and flexibility of the event system, especially around deep linking and permissions.