Merged
Conversation
lchrusciel
approved these changes
Aug 13, 2021
Contributor
|
Thank you, Mateusz! 🥇 |
10 tasks
GSadee
added a commit
to Sylius/SyliusGridBundle
that referenced
this pull request
Aug 16, 2021
This PR was merged into the 1.10-dev branch. Discussion ---------- The same as in Sylius/SyliusResourceBundle#328 🎉 Commits ------- be1a7d3 Upgrade required dependencies 017a91a Use PHP 7.4 syntax (finally)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better late than never 💃 I think we should upgrade the PHP syntax whenever we decide to bump the lowest PHP supported version (we would probably be bumping to PHP8.0 in the nearest months, which will also be a good opportunity to improve our codebase 🚀).