feat(notification): Translate resource name in flash messages#1146
Merged
NoResponseMate merged 1 commit intoSylius:1.15from Feb 9, 2026
Merged
Conversation
loic425
commented
Feb 9, 2026
|
|
||
| private function getParametersWithName(MetadataInterface $metadata, string $actionName): array | ||
| { | ||
| $applicationName = $metadata->getApplicationName(); |
Member
Author
There was a problem hiding this comment.
It fixes a translated custom resource in the legacy Flash helper
loic425
commented
Feb 9, 2026
|
|
||
| final class FlashHelper implements FlashHelperInterface | ||
| { | ||
| private const UI_TRANSLATION_PREFIX = 'sylius.ui.'; |
Member
Author
There was a problem hiding this comment.
This is not as simple as this...
NoResponseMate
approved these changes
Feb 9, 2026
NoResponseMate
added a commit
to Sylius/Sylius
that referenced
this pull request
Feb 9, 2026
| Q | A |-----------------|----- | Branch? | new-routing | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | partially #18212 | License | MIT <!-- - Bug fixes must be submitted against the 1.14 or 2.1 branch - Features and deprecations must be submitted against the 2.2 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> It will fix the build with the feature introduced in Sylius/SyliusResourceBundle#1146 I also moved the upgrade guide routing chapter from 2.2 to 2.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the feature added in #1089
It also adds the same feature in the new FlashHelper.