src/Sylius/Behat/Resources/config/services/elements/shop.php (1)

14-21: use imports are not sorted alphabetically.

MenuElement (line 15) should come after all CartWidget* and CheckoutSubtotal* imports. As per coding guidelines: "Sort PHP use imports alphabetically."

♻️ Proposed fix

 use Sylius\Behat\Element\Shop\Account\RegisterElement;
-use Sylius\Behat\Element\Shop\MenuElement;
 use Sylius\Behat\Element\Shop\CartWidgetElementInterface;
 use Sylius\Behat\Element\Shop\CartWidgetElement;
 use Sylius\Behat\Element\Shop\CheckoutSubtotalElementInterface;
 use Sylius\Behat\Element\Shop\CheckoutSubtotalElement;
+use Sylius\Behat\Element\Shop\MenuElement;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use function Symfony\Component\DependencyInjection\Loader\Configurator\service;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/shop.php` around lines 14
- 21, The use imports are not alphabetically ordered: move MenuElement so
imports follow alphabetical order relative to CartWidgetElementInterface,
CartWidgetElement, CheckoutSubtotalElementInterface, CheckoutSubtotalElement;
update the import block (affecting symbols MenuElement,
CartWidgetElementInterface, CartWidgetElement, CheckoutSubtotalElementInterface,
CheckoutSubtotalElement) so all use statements are sorted alphabetically to
comply with the project's coding guidelines.

src/Sylius/Behat/Resources/config/services/elements/admin/product_attribute.php (1)

14-18: use imports are not sorted alphabetically.

FilterElement (line 16) should precede FormElement (line 14) (Filter < Form), and AutocompleteHelperInterface (from Sylius\Behat\Service\) should follow both Element\ imports.

As per coding guidelines: "Sort PHP use imports alphabetically."

♻️ Proposed fix

-use Sylius\Behat\Element\Admin\ProductAttribute\FormElement;
-use Sylius\Behat\Service\Helper\AutocompleteHelperInterface;
-use Sylius\Behat\Element\Admin\ProductAttribute\FilterElement;
+use Sylius\Behat\Element\Admin\ProductAttribute\FilterElement;
+use Sylius\Behat\Element\Admin\ProductAttribute\FormElement;
+use Sylius\Behat\Service\Helper\AutocompleteHelperInterface;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@src/Sylius/Behat/Resources/config/services/elements/admin/product_attribute.php`
around lines 14 - 18, The use-imports in this file are not alphabetized; reorder
the imports so they are sorted alphabetically by full import string: place
Sylius\Behat\Element\Admin\ProductAttribute\FilterElement before
Sylius\Behat\Element\Admin\ProductAttribute\FormElement, and ensure
Sylius\Behat\Service\Helper\AutocompleteHelperInterface comes after the two
Element imports; keep the Symfony imports
(Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator
and the service function) in their proper alphabetical positions as well so all
use statements are fully sorted.

src/Sylius/Behat/Resources/config/services/elements/admin/product.php (1)

14-23: use imports are not sorted alphabetically.

Sylius\Behat\Element\Admin\Product\* (lines 16–21) should precede Sylius\Behat\Element\Admin\ProductAssociationType\FormElement (line 14), and Sylius\Behat\Service\Helper\AutocompleteHelperInterface (line 15, a Service\ namespace) should follow all Element\ imports.

As per coding guidelines: "Sort PHP use imports alphabetically."

♻️ Proposed fix

-use Sylius\Behat\Element\Admin\ProductAssociationType\FormElement;
-use Sylius\Behat\Service\Helper\AutocompleteHelperInterface;
-use Sylius\Behat\Element\Admin\Product\AssociationsFormElement;
-use Sylius\Behat\Element\Admin\Product\AttributesFormElement;
-use Sylius\Behat\Element\Admin\Product\ChannelPricingsFormElement;
-use Sylius\Behat\Element\Admin\Product\MediaFormElement;
-use Sylius\Behat\Element\Admin\Product\TaxonomyFormElement;
-use Sylius\Behat\Element\Admin\Product\TranslationsFormElement;
+use Sylius\Behat\Element\Admin\Product\AssociationsFormElement;
+use Sylius\Behat\Element\Admin\Product\AttributesFormElement;
+use Sylius\Behat\Element\Admin\Product\ChannelPricingsFormElement;
+use Sylius\Behat\Element\Admin\Product\MediaFormElement;
+use Sylius\Behat\Element\Admin\Product\TaxonomyFormElement;
+use Sylius\Behat\Element\Admin\Product\TranslationsFormElement;
+use Sylius\Behat\Element\Admin\ProductAssociationType\FormElement;
+use Sylius\Behat\Service\Helper\AutocompleteHelperInterface;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/admin/product.php` around
lines 14 - 23, Reorder the PHP use statements so they are alphabetically sorted:
move all Sylius\Behat\Element\Admin\Product\* imports (AssociationsFormElement,
AttributesFormElement, ChannelPricingsFormElement, MediaFormElement,
TaxonomyFormElement, TranslationsFormElement) before
Sylius\Behat\Element\Admin\ProductAssociationType\FormElement and place
Sylius\Behat\Service\Helper\AutocompleteHelperInterface after the Element
imports; ensure
Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator
and the service() import remain in correct alphabetical order relative to the
others so the entire block is alphabetized.

src/Sylius/Behat/Resources/config/services/elements/product.php (1)

14-27: use imports are not sorted alphabetically.

Within the ShowPage namespace, TranslationsElement (T) appears before PricingElement (P), OptionsElement (O) appears after ShippingElement/TaxonomyElement, and the LowestPrice* imports should be grouped between DetailsElement and MediaElement. VerticalMenuElement (from IndexPage, which sorts before ShowPage) should also precede the ShowPage imports.

As per coding guidelines: "Sort PHP use imports alphabetically."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/product.php` around lines
14 - 27, The use imports are out-of-order; reorder them alphabetically and group
related namespaces: place VerticalMenuElement (IndexPage) before the ShowPage
imports, then within ShowPage sort alphabetically so DetailsElement is followed
by LowestPriceInformationElementInterface and LowestPriceInformationElement,
then MediaElement, OptionsElement, Ordering others (AssociationsElement,
AttributesElement, DetailsElement, LowestPriceInformationElementInterface,
LowestPriceInformationElement, MediaElement, PricingElement, ShippingElement,
TaxonomyElement, TranslationsElement, VariantsElement), ensuring all import
lines (e.g., AssociationsElement, AttributesElement, DetailsElement,
LowestPriceInformationElementInterface, LowestPriceInformationElement,
MediaElement, PricingElement, ShippingElement, TaxonomyElement, OptionsElement,
TranslationsElement, VariantsElement, VerticalMenuElement) follow PHP
alphabetical ordering.

src/Sylius/Behat/Resources/config/services/elements/admin.php (2)

14-33: use imports are not sorted alphabetically.

Multiple ordering violations: Account\ResetElement (line 16) should come before Crud\* imports (lines 14–15), and Sylius\Behat\Service\Helper\AutocompleteHelperInterface (line 21, Service\ namespace) should follow all Element\ imports. Within Admin\, alphabetical order would be: Account < CatalogPromotion < Channel < Crud < Notifications < Promotion < Taxon < TopBar.

As per coding guidelines: "Sort PHP use imports alphabetically."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/admin.php` around lines
14 - 33, The imports are not alphabetically ordered; reorder the use statements
so all Sylius\Behat\Element\* imports are sorted alphabetically by full
namespace segment (within Admin: Account, CatalogPromotion, Channel, Crud,
Notifications, Promotion, Taxon, TopBar) and ensure interface names come before
their implementations (e.g.,
DiscountedProductsCheckingPeriodInputElementInterface before
DiscountedProductsCheckingPeriodInputElement, LowestPriceFlagElementInterface
before LowestPriceFlagElement,
ExcludeTaxonsFromShowingLowestPriceInputElementInterface before its
implementation), specifically move ResetElement (Account\ResetElement) to appear
before Crud\FormElement/SearchFilterElement and place
AutocompleteHelperInterface
(Sylius\Behat\Service\Helper\AutocompleteHelperInterface) after all Element\
imports; apply the same alphabetical ordering to FilterElement and
FormElementInterface as part of this reorder.

---

74-178: Replace inline FQCNs with use imports.

Multiple service definitions use inline fully-qualified class names (e.g., \Sylius\Behat\Element\Admin\CatalogPromotion\FormElement::class at line 74, \Sylius\Behat\Element\Admin\ShippingMethod\FormElement::class at line 112, \Sylius\Behat\Element\Admin\Customer\FormElement::class at line 122, etc.) while others already use imported aliases. All non-global classes should be declared via use statements.

As per coding guidelines: "Use use statements for all non-global classes in PHP."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/admin.php` around lines
74 - 178, Several service definitions use inline FQCNs instead of imported class
names; replace those inline references with use imports and then use the
imported short class names in the service definitions. Specifically, add use
statements for classes seen in the diff such as
Sylius\Behat\Element\Admin\CatalogPromotion\FormElement,
Sylius\Behat\Element\Admin\TaxRate\FilterElement,
Sylius\Behat\Element\Admin\Promotion\FormElement,
Sylius\Behat\Element\Admin\ShippingMethod\FormElement,
Sylius\Behat\Element\Admin\ProductOption\FormElement,
Sylius\Behat\Element\Admin\Customer\FormElement,
Sylius\Behat\Element\Admin\Zone\FormElement,
Sylius\Behat\Element\Admin\Taxon\FormElement,
Sylius\Behat\Element\Admin\Taxon\ImageFormElement (ImageFormElement already
used), Sylius\Behat\Element\Admin\Taxon\TreeElement (TreeElement already used),
Sylius\Behat\Element\Admin\PromotionCoupon\FormElement,
Sylius\Behat\Element\Admin\TaxCategory\FormElement,
Sylius\Behat\Element\Admin\Currency\FormElement,
Sylius\Behat\Element\Admin\Locale\FormElement,
Sylius\Behat\Element\Admin\ExchangeRate\FormElement,
Sylius\Behat\Element\Admin\CustomerGroup\FormElement (and any other
fully-qualified names in this file), then update each ->set(...) call to
reference the imported class name (remove leading backslashes and inline FQCNs)
so all non-global classes are declared via use statements per the coding
guideline.

src/Sylius/Behat/Resources/config/services/elements/common.php (1)

23-40: sylius.behat.element.browser and sylius.behat.element.save are missing explicit visibility.

shop.php and product.php both call $services->defaults()->public() and then mark each concrete service ->private(). common.php sets no defaults, so BrowserElement and SaveElement will use the container's default visibility (public in test environments, but inconsistent with the pattern in sibling files).

🔧 Proposed fix

 return static function (ContainerConfigurator $container) {
     $services = $container->services();
+
+    $services->defaults()->public();

     $services
         ->set('sylius.behat.element', Element::class)
         ->abstract()
         ->args([
             service('behat.mink.default_session'),
             service('behat.mink.parameters'),
         ])
     ;

     $services
         ->set('sylius.behat.element.browser', BrowserElement::class)
+        ->private()
         ->parent('sylius.behat.element')
     ;

     $services
         ->set('sylius.behat.element.save', SaveElement::class)
+        ->private()
         ->parent('sylius.behat.element')
     ;
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/common.php` around lines
23 - 40, The two service definitions sylius.behat.element.browser
(BrowserElement::class) and sylius.behat.element.save (SaveElement::class) lack
explicit visibility and will inherit inconsistent defaults; update both service
registrations to declare their visibility explicitly (e.g., append ->private()
to each ->set(...)->parent('sylius.behat.element') call) so they match the
visibility pattern used in sibling files.

src/Sylius/Behat/Resources/config/services/elements/admin/product.php (1)

25-68: Services are missing explicit ->private() visibility — inconsistent with sibling files.

shop.php and product.php both call $services->defaults()->public() and mark each concrete service ->private(). This file sets no defaults and no ->private(), making these services publicly visible by default, which is inconsistent. Consider aligning with the pattern used in the peer files.

🔧 Proposed fix

 return static function (ContainerConfigurator $container) {
     $services = $container->services();
+
+    $services->defaults()->public();

     $services
         ->set('sylius.behat.element.admin.product_association_type.form', FormElement::class)
+        ->private()
         ->parent('sylius.behat.element.admin.crud.form')
         ->args([service(AutocompleteHelperInterface::class)])
     ;
     // ... apply ->private() to each remaining service definition

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/admin/product.php` around
lines 25 - 68, The services in this file (e.g.
'sylius.behat.element.admin.product_association_type.form' ->
FormElement::class, 'sylius.behat.element.admin.product.association_form' ->
AssociationsFormElement::class, etc.) are left public by omission; make them
private to match sibling files by adding ->private() to each service definition
(or call $services->defaults()->private() before the ->set(...) blocks) so every
concrete service is explicitly private.

src/Sylius/Behat/Resources/config/services/elements/admin/product.php (1)

14-23: ⚠️ Potential issue | 🟡 Minor

use imports are not sorted alphabetically — unresolved from previous review.

All Sylius\Behat\Element\Admin\Product\* class imports should precede Sylius\Behat\Element\Admin\ProductAssociationType\FormElement (Product\ < ProductAssociationType\), and Sylius\Behat\Service\Helper\AutocompleteHelperInterface should follow all Sylius\Behat\Element\* imports (Element < Service).

♻️ Proposed fix

-use Sylius\Behat\Element\Admin\ProductAssociationType\FormElement;
-use Sylius\Behat\Service\Helper\AutocompleteHelperInterface;
 use Sylius\Behat\Element\Admin\Product\AssociationsFormElement;
 use Sylius\Behat\Element\Admin\Product\AttributesFormElement;
 use Sylius\Behat\Element\Admin\Product\ChannelPricingsFormElement;
 use Sylius\Behat\Element\Admin\Product\MediaFormElement;
 use Sylius\Behat\Element\Admin\Product\TaxonomyFormElement;
 use Sylius\Behat\Element\Admin\Product\TranslationsFormElement;
+use Sylius\Behat\Element\Admin\ProductAssociationType\FormElement;
+use Sylius\Behat\Service\Helper\AutocompleteHelperInterface;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use function Symfony\Component\DependencyInjection\Loader\Configurator\service;

As per coding guidelines: "Sort PHP use imports alphabetically and group by type (classes, functions, constants)."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/admin/product.php` around
lines 14 - 23, The use imports in this file are out of alphabetical order;
reorder and group them so all Sylius\Behat\Element\Admin\Product\* imports
(AssociationsFormElement, AttributesFormElement, ChannelPricingsFormElement,
MediaFormElement, TaxonomyFormElement, TranslationsFormElement) appear before
Sylius\Behat\Element\Admin\ProductAssociationType\FormElement, and place
Sylius\Behat\Service\Helper\AutocompleteHelperInterface after the Element
imports; keep the function import (service) in its own group after class
imports. Ensure imports are alphabetized within their groups and that the
grouping follows classes first then functions/constants.

src/Sylius/Behat/Resources/config/services/elements/product.php (1)

14-27: ⚠️ Potential issue | 🟡 Minor

use imports are not sorted alphabetically — unresolved from previous review.

IndexPage\VerticalMenuElement (line 26) should precede all ShowPage\* imports (IndexPage < ShowPage). Within ShowPage\*, LowestPrice* (lines 24–25, L) should appear before MediaElement (line 17, M), and OptionsElement (line 22, O) before PricingElement (line 19, P) — which itself should precede ShippingElement (line 20), TaxonomyElement (line 21), and TranslationsElement (line 18).

♻️ Proposed fix

-use Sylius\Behat\Element\Product\ShowPage\AssociationsElement;
-use Sylius\Behat\Element\Product\ShowPage\AttributesElement;
-use Sylius\Behat\Element\Product\ShowPage\DetailsElement;
-use Sylius\Behat\Element\Product\ShowPage\MediaElement;
-use Sylius\Behat\Element\Product\ShowPage\TranslationsElement;
-use Sylius\Behat\Element\Product\ShowPage\PricingElement;
-use Sylius\Behat\Element\Product\ShowPage\ShippingElement;
-use Sylius\Behat\Element\Product\ShowPage\TaxonomyElement;
-use Sylius\Behat\Element\Product\ShowPage\OptionsElement;
-use Sylius\Behat\Element\Product\ShowPage\VariantsElement;
-use Sylius\Behat\Element\Product\ShowPage\LowestPriceInformationElementInterface;
-use Sylius\Behat\Element\Product\ShowPage\LowestPriceInformationElement;
-use Sylius\Behat\Element\Product\IndexPage\VerticalMenuElement;
+use Sylius\Behat\Element\Product\IndexPage\VerticalMenuElement;
+use Sylius\Behat\Element\Product\ShowPage\AssociationsElement;
+use Sylius\Behat\Element\Product\ShowPage\AttributesElement;
+use Sylius\Behat\Element\Product\ShowPage\DetailsElement;
+use Sylius\Behat\Element\Product\ShowPage\LowestPriceInformationElement;
+use Sylius\Behat\Element\Product\ShowPage\LowestPriceInformationElementInterface;
+use Sylius\Behat\Element\Product\ShowPage\MediaElement;
+use Sylius\Behat\Element\Product\ShowPage\OptionsElement;
+use Sylius\Behat\Element\Product\ShowPage\PricingElement;
+use Sylius\Behat\Element\Product\ShowPage\ShippingElement;
+use Sylius\Behat\Element\Product\ShowPage\TaxonomyElement;
+use Sylius\Behat\Element\Product\ShowPage\TranslationsElement;
+use Sylius\Behat\Element\Product\ShowPage\VariantsElement;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

As per coding guidelines: "Sort PHP use imports alphabetically and group by type (classes, functions, constants)."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/product.php` around lines
14 - 27, The use imports are not sorted alphabetically; reorder the class
imports so IndexPage\VerticalMenuElement appears before all ShowPage\* imports,
and within the ShowPage group place LowestPriceInformationElementInterface and
LowestPriceInformationElement (LowestPrice*) before MediaElement, place
OptionsElement before PricingElement, and ensure PricingElement comes before
ShippingElement, TaxonomyElement and TranslationsElement; also ensure imports
are grouped by type (classes) and duplicate imports removed so the list is
strictly alphabetized.

src/Sylius/Behat/Resources/config/services/elements/product.php (1)

32-104: Redundant ->defaults()->public() + per-service ->private() pattern.

Setting defaults to public() (line 32) and then calling ->private() on every individual service has the same net result as simply setting defaults to private(). The current pattern requires adding ->private() to each new service added in future, creating unnecessary maintenance overhead.

♻️ Proposed simplification

-    $services->defaults()->public();
+    $services->defaults()->private();

     $services
         ->set('sylius.behat.element.product.show.associations', AssociationsElement::class)
-        ->private()
         ->parent('sylius.behat.element')
     ;

     $services
         ->set('sylius.behat.element.product.show.attributes', AttributesElement::class)
-        ->private()
         ->parent('sylius.behat.element')
     ;
     // ... repeat for all remaining services

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Sylius/Behat/Resources/config/services/elements/product.php` around lines
32 - 104, The file sets $services->defaults()->public() then marks each service
private with ->private(); change the defaults call to
$services->defaults()->private() and remove the unnecessary per-service
->private() calls (for services like
'sylius.behat.element.product.show.associations',
'sylius.behat.element.product.show.attributes',
'sylius.behat.element.product.show.details',
'sylius.behat.element.product.show.media',
'sylius.behat.element.product.show.more_details',
'sylius.behat.element.product.show.pricing',
'sylius.behat.element.product.show.shipping',
'sylius.behat.element.product.show.taxonomy',
'sylius.behat.element.product.show.options',
'sylius.behat.element.product.show.variants', the
LowestPriceInformationElementInterface binding, and
'sylius.behat.element.product.index.vertical_menu') so they inherit the private
default and you no longer need to repeat ->private() on each ->set(...) call.

Configuration used: defaults

Review profile: CHILL

Plan: Pro