src/Sylius/Bundle/ApiBundle/Resources/config/services/controllers.php (1)

1-5: Add declare(strict_types=1); and return type to the closure.

The file is missing the strict types declaration required by the coding guidelines. Additionally, the closure should have a void return type for completeness.

♻️ Proposed fix

 <?php
 
+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {
     $services = $container->services();

As per coding guidelines: "Declare strict_types=1 at the beginning of all PHP files" and "Add type declarations for all properties, arguments, and return values in PHP code".

src/Sylius/Bundle/ApiBundle/Resources/config/services/security.php (1)

13-15: Redundant security.voter tag on order_adjustments voter.

The ->tag('security.voter') on Line 15 is redundant since defaults() on Lines 8-9 already applies this tag to all services in this file.

Proposed fix

     $services->set('sylius_api.security.voter.order_adjustments', 'Sylius\Bundle\ApiBundle\Security\OrderAdjustmentsVoter')
-        ->args([service('sylius_api.provider.adjustment_order')])
-        ->tag('security.voter');
+        ->args([service('sylius_api.provider.adjustment_order')]);
 };

src/Sylius/Bundle/ApiBundle/Resources/config/services/resolvers.php (1)

8-14: Consider using ::class constants instead of string class names.

Using ::class constants improves IDE support, enables better static analysis, and makes refactoring safer.

Proposed refactor

+use Sylius\Bundle\ApiBundle\Resolver\OperationResolverInterface;
+use Sylius\Bundle\ApiBundle\Resolver\PathPrefixBasedOperationResolver;
+use Sylius\Bundle\ApiBundle\Resolver\UriTemplateParentResourceResolver;
+
 return static function (ContainerConfigurator $container) {
     $services = $container->services();
 
-    $services->set('sylius_api.operation_resolver.path_prefix_based', 'Sylius\Bundle\ApiBundle\Resolver\PathPrefixBasedOperationResolver')
+    $services->set('sylius_api.operation_resolver.path_prefix_based', PathPrefixBasedOperationResolver::class)
         ->args([service('api_platform.metadata.resource.metadata_collection_factory')]);
 
-    $services->alias('Sylius\Bundle\ApiBundle\Resolver\OperationResolverInterface', 'sylius_api.operation_resolver.path_prefix_based');
+    $services->alias(OperationResolverInterface::class, 'sylius_api.operation_resolver.path_prefix_based');
 
-    $services->set('sylius_api.resolver.uri_template_parent_resource_resolver', 'Sylius\Bundle\ApiBundle\Resolver\UriTemplateParentResourceResolver')
+    $services->set('sylius_api.resolver.uri_template_parent_resource_resolver', UriTemplateParentResourceResolver::class)
         ->args([service('doctrine.orm.entity_manager')]);
 };

src/Sylius/Bundle/ApiBundle/Resources/config/services/command_handlers.php (1)

8-17: Consider using ::class constants instead of string literals for handler classes.

Using ::class constants provides better IDE support (autocompletion, refactoring), catches typos at compile time, and makes it easier to track usages. This applies to all handler class definitions in this file.

Example refactor for the first handler

+use Sylius\Bundle\ApiBundle\CommandHandler\Account\RegisterShopUserHandler;
+
 return static function (ContainerConfigurator $container) {
     $services = $container->services();
 
-    $services->set('sylius_api.command_handler.account.register_shop_user', 'Sylius\Bundle\ApiBundle\CommandHandler\Account\RegisterShopUserHandler')
+    $services->set('sylius_api.command_handler.account.register_shop_user', RegisterShopUserHandler::class)

src/Sylius/Bundle/ApiBundle/Resources/config/services/api_payment_methods.php (2)

1-6: Add strict_types and an explicit void return type.

This keeps the config file aligned with the PHP type-safety rules used elsewhere.

Proposed change

 <?php

+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function(ContainerConfigurator $container): void {

As per coding guidelines: Declare `strict_types=1` at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

---

3-13: Prefer ::class constants with imports for service wiring.

Using class constants improves refactor safety and matches the required import usage.

Proposed change

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

+use Sylius\Bundle\ApiBundle\Provider\CompositePaymentConfigurationProvider;
+use Sylius\Bundle\ApiBundle\Provider\CompositePaymentConfigurationProviderInterface;

-$services->set('sylius_api.provider.payment_configuration', 'Sylius\Bundle\ApiBundle\Provider\CompositePaymentConfigurationProvider')
+$services->set('sylius_api.provider.payment_configuration', CompositePaymentConfigurationProvider::class)
     ->args([tagged_iterator('sylius.api.payment_method_handler')]);

-    $services->alias('Sylius\Bundle\ApiBundle\Provider\CompositePaymentConfigurationProviderInterface', 'sylius_api.provider.payment_configuration');
+    $services->alias(CompositePaymentConfigurationProviderInterface::class, 'sylius_api.provider.payment_configuration');

As per coding guidelines: Use `use` statements for all non-global classes in PHP.

src/Sylius/Bundle/ApiBundle/Resources/config/services/payments.php (2)

1-6: Add strict_types and an explicit void return type.

This keeps the config file aligned with the PHP type-safety rules used elsewhere.

Proposed change

 <?php

+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function(ContainerConfigurator $container): void {

As per coding guidelines: Declare `strict_types=1` at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

---

3-15: Prefer ::class constants with imports for service wiring.

Using class constants improves refactor safety and matches the required import usage.

Proposed change

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

+use Sylius\Bundle\ApiBundle\Controller\Payment\GetPaymentConfiguration;

-$services->set('sylius_api.controller.payment.get_payment_configuration', 'Sylius\Bundle\ApiBundle\Controller\Payment\GetPaymentConfiguration')
+$services->set('sylius_api.controller.payment.get_payment_configuration', GetPaymentConfiguration::class)
     ->args([
         service('sylius.repository.payment'),
         service('sylius_api.provider.payment_configuration'),
     ]);

As per coding guidelines: Use `use` statements for all non-global classes in PHP.

src/Sylius/Bundle/ApiBundle/Resources/config/services/event_subscribers.php (1)

1-6: Add strict_types and a void return type to the configurator closure.

This file should declare strict types and the closure should declare its return type.

♻️ Suggested update

 <?php
+
+declare(strict_types=1);

- return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/ApiBundle/Resources/config/integrations/swagger.php (1)

1-6: Add strict_types and a void return type to the configurator closure.

This file should declare strict types and the closure should declare its return type.

♻️ Suggested update

 <?php
+
+declare(strict_types=1);

- return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/ApiBundle/Resources/config/services/query_handlers.php (1)

1-6: Add strict_types and a void return type to the configurator closure.

This file should declare strict types and the closure should declare its return type.

♻️ Suggested update

 <?php
+
+declare(strict_types=1);

- return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/ApiBundle/Resources/config/services.php (1)

1-8: Add strict_types and a void return type to the configurator closure.

This file should declare strict types and the closure should declare its return type.

♻️ Suggested update

 <?php
+
+declare(strict_types=1);

- return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/ApiBundle/Resources/config/services/api_platform.php (1)

1-8: Add strict_types and a void return type to the configurator closure.

This file should declare strict types and the closure should declare its return type.

♻️ Suggested update

 <?php
+
+declare(strict_types=1);

- return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/ApiBundle/Resources/config/services/serializers.php (1)

1-8: Add strict_types and a void return type to the configurator closure.

This file should declare strict types and the closure should declare its return type.

♻️ Suggested update

 <?php
+
+declare(strict_types=1);

- return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/ApiBundle/Resources/config/services/extensions.php (1)

1-2: Missing declare(strict_types=1) declaration.

Per coding guidelines, all PHP files should declare strict types at the beginning.

Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/ApiBundle/Resources/config/services/context_builders.php (1)

1-2: Missing declare(strict_types=1) declaration.

Per coding guidelines, all PHP files should declare strict types at the beginning.

Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/ApiBundle/Resources/config/services/validator.php (1)

1-2: Missing declare(strict_types=1) declaration.

Per coding guidelines, all PHP files should declare strict types at the beginning.

Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/ApiBundle/Resources/config/services/admin/filters.php (1)

1-2: Missing declare(strict_types=1) declaration.

Per coding guidelines, all PHP files should declare strict types at the beginning.

Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/ApiBundle/Resources/config/services/shop/filters.php (1)

1-2: Missing declare(strict_types=1) declaration.

Per coding guidelines, all PHP files should declare strict types at the beginning.

Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/ApiBundle/Resources/config/services/event_handlers.php (1)

11-11: Consider using ::class constant instead of string class name.

Using OrderCompletedHandler::class provides better IDE support, enables refactoring tools, and catches typos at compile time.

Suggested fix

+use Sylius\Bundle\ApiBundle\EventHandler\OrderCompletedHandler;
+
 return static function (ContainerConfigurator $container): void {
     $services = $container->services();

     $services->defaults()
         ->public();

-    $services->set('sylius_api.event_handler.order_completed', 'Sylius\Bundle\ApiBundle\EventHandler\OrderCompletedHandler')
+    $services->set('sylius_api.event_handler.order_completed', OrderCompletedHandler::class)
         ->args([

src/Sylius/Bundle/ApiBundle/Resources/config/services/state_processors.php (1)

8-103: Add trailing commas to multi-line argument lists.

Per coding guidelines, multi-line arrays and argument lists should use trailing commas to facilitate cleaner diffs and easier additions.

Example fix for one service (apply pattern to all)

     $services->set('sylius_api.state_processor.admin.admin_user.remove', 'Sylius\Bundle\ApiBundle\StateProcessor\Admin\AdminUser\RemoveProcessor')
         ->args([
             service('api_platform.doctrine.orm.state.remove_processor'),
-            service('security.token_storage'),
+            service('security.token_storage'),
         ])
         ->tag('api_platform.state_processor');

Apply the same pattern to all ->args([...]) blocks, ensuring the last element has a trailing comma.

src/Sylius/Bundle/ApiBundle/Resources/config/services/admin/filters.php (1)

159-164: Add trailing comma in multi-line argument list.

Per coding guidelines, multi-line arrays and argument lists should use trailing commas for cleaner diffs and easier maintenance.

Proposed fix

     $services->set('sylius_api.catalog_promotion_search_filter.admin.product_variant', 'Sylius\Bundle\ApiBundle\Doctrine\ORM\Filter\ProductVariantCatalogPromotionFilter')
         ->args([
             service('api_platform.symfony.iri_converter'),
-            service('doctrine'),
+            service('doctrine'),
         ])
         ->tag('api_platform.filter');

Note: The same applies to the ChannelsAwareChannelFilter definition at lines 186-191.

src/Sylius/Bundle/ApiBundle/Resources/config/services/admin/state_providers.php (2)

5-6: Add an explicit : void return type to the configurator closure.

This closure doesn't return a value, so declare it explicitly.
As per coding guidelines: "Add type declarations for all properties, arguments, and return values in PHP code".

✅ Proposed fix

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

---

8-20: Prefer ::class with a use import instead of string class names.

This is more refactor-safe and aligns with the import guideline.
As per coding guidelines: "Use use statements for all non-global classes in PHP".

✅ Proposed fix

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
+use Sylius\Bundle\ApiBundle\StateProvider\Common\Adjustment\CollectionProvider;
+
 return static function (ContainerConfigurator $container): void {
     $services = $container->services();
 
-    $services->set('sylius_api.state_provider.admin.order.adjustment.collection', 'Sylius\Bundle\ApiBundle\StateProvider\Common\Adjustment\CollectionProvider')
+    $services->set('sylius_api.state_provider.admin.order.adjustment.collection', CollectionProvider::class)
         ->args([
             service('sylius.repository.order'),
             'tokenValue',
         ])
         ->tag('api_platform.state_provider', ['priority' => 10]);
 
-    $services->set('sylius_api.state_provider.admin.order_item.adjustment.collection', 'Sylius\Bundle\ApiBundle\StateProvider\Common\Adjustment\CollectionProvider')
+    $services->set('sylius_api.state_provider.admin.order_item.adjustment.collection', CollectionProvider::class)
         ->args([
             service('sylius.repository.order_item'),
             'id',
         ])
         ->tag('api_platform.state_provider', ['priority' => 10]);
 };

src/Sylius/Bundle/ApiBundle/Resources/config/services/serializers.php (1)

95-126: Minor inconsistency: service(RequestStack::class) vs service('request_stack').

Line 98 uses the string service ID service('request_stack') for the ImageNormalizer, while line 123 uses the FQCN service(RequestStack::class) for the ShippingMethodNormalizer. Both resolve to the same service, but mixing styles reduces readability. Consider standardizing on one form.

Proposed fix (use string ID consistently)

     $services->set('sylius_api.normalizer.shipping_method', ShippingMethodNormalizer::class)
         ->args([
             service('sylius.section_resolver.uri_based'),
             service('sylius.repository.order'),
             service('sylius.repository.shipment'),
             service('sylius.registry.shipping_calculator'),
-            service(RequestStack::class),
+            service('request_stack'),
             ['sylius:shop:shipping_method:index'],
         ])
         ->tag('serializer.normalizer', ['priority' => 64]);

src/Sylius/Bundle/ApiBundle/Resources/config/services/state_processors.php (1)

31-31: Add : void return type to the closure, and consider applying this fix systematically across all sibling service configuration files.

The closure at line 31 lacks a return type declaration. This pattern is consistent across all 23 service configuration files in src/Sylius/Bundle/ApiBundle/Resources/config/services/ (e.g., validators.php, serializers.php, security.php, and others), which should ideally be updated together for consistency per the coding guideline: "Add type declarations for all properties, arguments, and return values in PHP code".

Proposed fix

-return static function (ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {