src/Sylius/Bundle/CoreBundle/Controller/OrderController.php (1)

62-62: Consider enhancing the deprecation notice with a @see reference and runtime trigger.

The docblock deprecation is good, but for better developer experience:

1. Add a @see tag pointing to the replacement (OrderThankYouController)
2. Consider triggering a runtime deprecation notice so developers are alerted during execution

♻️ Suggested enhancement

-    /** `@deprecated` This method is deprecated and will be removed in Sylius 3.0 */
+    /**
+     * `@deprecated` since Sylius 2.3, will be removed in Sylius 3.0. Use {`@see` \Sylius\Bundle\ShopBundle\Controller\OrderThankYouController} instead.
+     */
     public function thankYouAction(Request $request): Response
     {
+        trigger_deprecation(
+            'sylius/sylius',
+            '2.3',
+            'The "%s::thankYouAction()" method is deprecated and will be removed in Sylius 3.0. Use "%s" instead.',
+            self::class,
+            \Sylius\Bundle\ShopBundle\Controller\OrderThankYouController::class,
+        );
+
         $configuration = $this->requestConfigurationFactory->create($this->metadata, $request);

src/Sylius/Bundle/ShopBundle/Controller/OrderThankYouController.php (1)

27-31: Consider marking constructor properties as readonly.

Per coding guidelines, immutable services should use readonly. Since these dependencies are injected once and never modified, marking them as readonly provides additional safety.

♻️ Suggested enhancement

     public function __construct(
-        private Environment $twig,
-        private OrderRepositoryInterface $orderRepository,
-        private RouterInterface $router,
+        private readonly Environment $twig,
+        private readonly OrderRepositoryInterface $orderRepository,
+        private readonly RouterInterface $router,
     ) {
     }

src/Sylius/Bundle/ShopBundle/Resources/config/routing/order.yml (1)

7-9: Remove the empty defaults: block.

The defaults: block on line 8 appears to be empty (line 9 is blank). Since the controller: key already sets the controller and no other defaults are needed, the empty block should be removed for cleaner configuration.

♻️ Suggested cleanup

 sylius_shop_order_thank_you:
     path: /thank-you
     methods: [GET]
     controller: sylius_shop.controller.order_thank_you
-    defaults:
 
 sylius_shop_order_pay:

src/Sylius/Bundle/CoreBundle/Controller/OrderController.php (1)

62-63: Consider adding a runtime deprecation trigger.

The @deprecated docblock is good for IDE hints, but won't warn developers at runtime. Consider triggering a deprecation notice at the start of the method body using Symfony's trigger_deprecation() function:

     /** `@deprecated` This method is deprecated and will be removed in Sylius 3.0 */
     public function thankYouAction(Request $request): Response
     {
+        trigger_deprecation(
+            'sylius/sylius',
+            '2.3',
+            'The "%s" method is deprecated and will be removed in Sylius 3.0. Use "%s" instead.',
+            __METHOD__,
+            OrderThankYouAction::class,
+        );
+
         $configuration = $this->requestConfigurationFactory->create($this->metadata, $request);

This requires adding the use function Symfony\Component\Deprecation\trigger_deprecation; import.