[XML2PHP] OrderBundle by crydotsnake · Pull Request #18766 · Sylius/Sylius

crydotsnake · 2026-01-31T10:53:21Z

Q	A
Branch?	2.3
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	partially #18490
License	MIT

Summary by CodeRabbit

Refactor
- Migrated OrderBundle service configuration from XML to PHP and updated the DI loader to support PHP configs.
New Features
- Reintroduced order-related services and form types (order, cart, order item, cart item) with validation groups.
- Added a Twig extension to expose aggregated order adjustments.
- Restored expired-carts removal and cart-reset command/operations and public access points for number assignment and cart-change resetting.

coderabbitai · 2026-01-31T10:53:31Z

📝 Walkthrough

Walkthrough

Migrates OrderBundle service configuration from XML to PHP (replacing XmlFileLoader with PhpFileLoader), adds new PHP DI files for services, forms, integrations, and twig, removes corresponding XML files, and adds inline_service to composer-require-checker.json symbol whitelist.

Changes

Cohort / File(s)	Summary
Composer whitelist `composer-require-checker.json`	Added `inline_service` to `symbol-whitelist` (placed before existing `service`).
Extension loader `src/Sylius/Bundle/OrderBundle/DependencyInjection/SyliusOrderExtension.php`	Switched from `XmlFileLoader` to `PhpFileLoader` and updated load paths/extensions from `.xml` to `.php` for services and integration drivers.
Core services (XML → PHP) `src/Sylius/Bundle/OrderBundle/Resources/config/services.php`, `src/Sylius/Bundle/OrderBundle/Resources/config/services.xml`	Added `services.php` with full DI wiring for order features (commands, contexts, processors, modifiers, generators, assigners, decorators, removers, factories); removed the old `services.xml`.
Form services (XML → PHP) `src/Sylius/Bundle/OrderBundle/Resources/config/services/form.php`, `.../services/form.xml`	Added `form.php` defining form types, data mapper service and validation group parameters; removed `form.xml`.
Integrations (Doctrine) (XML → PHP) `src/Sylius/Bundle/OrderBundle/Resources/config/services/integrations/doctrine/orm.php`, `.../integrations/doctrine/orm.xml`	Added `orm.php` setting repository class parameters; removed `orm.xml`.
Twig extension (XML → PHP) `src/Sylius/Bundle/OrderBundle/Resources/config/services/twig.php`, `.../services/twig.xml`	Added `twig.php` registering `sylius.twig.extension.aggregate_adjustments`; removed `twig.xml`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

[XML2PHP] LocaleBundle #18764 — Similar XML→PHP service-config migration in another bundle (same loader/type changes).
[XML2PHP] MoneyBundle #18765 — Same Xml→Php loader migration pattern across bundles.
[UPMERGE] 1.14 -> 2.0 #17604 — Related changes around CartChangesResetter registration and DI wiring.

Suggested labels

Maintenance

Suggested reviewers

TheMilek

Poem

🐰 I hopped through configs, XML to PHP bright,
Inline services lined up, tidy and light,
Cart crumbs and commands now wired with care,
Twig and repos awake in code fresh and fair,
A little rabbit cheers this migration flight! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '[XML2PHP] OrderBundle' directly describes the primary change: converting OrderBundle configuration from XML to PHP format across multiple configuration files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-31T10:54:50Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

src/Sylius/Bundle/OrderBundle/Resources/config/services/integrations/doctrine/orm.php

src/Sylius/Bundle/OrderBundle/Resources/config/services/twig.php

TheMilek · 2026-02-02T07:59:35Z

src/Sylius/Bundle/OrderBundle/Resources/config/services.php

+    $services = $container->services();
+    $parameters = $container->parameters();
+    $container->import('services/form.php');
+    $container->import('services/twig.php');


Suggested change

$services = $container->services();

$parameters = $container->parameters();

$container->import('services/form.php');

$container->import('services/twig.php');

$container->import('services/form.php');

$container->import('services/twig.php');

$services = $container->services();

$parameters = $container->parameters();

TheMilek · 2026-02-02T08:07:32Z

src/Sylius/Bundle/OrderBundle/Resources/config/services.php

+    $services->set('sylius.remover.expired_carts', ExpiredCartsRemover::class)
+        ->args([
+            service('sylius.repository.order'),
+            service('sylius.manager.order'),
+            service('event_dispatcher'),
+            '%sylius_order.cart_expiration_period%',
+        ]);
+
+    $services->alias(ExpiredCartsRemoverInterface::class, 'sylius.remover.expired_carts');
+
+    $services->set('sylius.factory.add_to_cart_command', AddToCartCommandFactory::class);
+
+    $services->alias(AddToCartCommandFactoryInterface::class, 'sylius.factory.add_to_cart_command');


Suggested change

$services->set('sylius.remover.expired_carts', ExpiredCartsRemover::class)

->args([

service('sylius.repository.order'),

service('sylius.manager.order'),

service('event_dispatcher'),

'%sylius_order.cart_expiration_period%',

]);

$services->alias(ExpiredCartsRemoverInterface::class, 'sylius.remover.expired_carts');

$services->set('sylius.factory.add_to_cart_command', AddToCartCommandFactory::class);

$services->alias(AddToCartCommandFactoryInterface::class, 'sylius.factory.add_to_cart_command');

$services->set('sylius.remover.expired_carts', ExpiredCartsRemover::class)

->args([

service('sylius.repository.order'),

service('sylius.manager.order'),

service('event_dispatcher'),

'%sylius_order.cart_expiration_period%',

]);

$services->alias(ExpiredCartsRemoverInterface::class, 'sylius.remover.expired_carts');

$services->set('sylius.factory.add_to_cart_command', AddToCartCommandFactory::class);

$services->alias(AddToCartCommandFactoryInterface::class, 'sylius.factory.add_to_cart_command');

TheMilek · 2026-02-02T08:07:46Z

src/Sylius/Bundle/OrderBundle/Resources/config/services.php

+    $services->set('sylius.resetter.cart_changes', CartChangesResetter::class)
+        ->public()
+        ->args([service('sylius.manager.order')]);
+
+    $services->alias(CartChangesResetterInterface::class, 'sylius.resetter.cart_changes');


Suggested change

$services->set('sylius.resetter.cart_changes', CartChangesResetter::class)

->public()

->args([service('sylius.manager.order')]);

$services->alias(CartChangesResetterInterface::class, 'sylius.resetter.cart_changes');

$services->set('sylius.resetter.cart_changes', CartChangesResetter::class)

->public()

->args([service('sylius.manager.order')]);

$services->alias(CartChangesResetterInterface::class, 'sylius.resetter.cart_changes');

TheMilek · 2026-02-02T08:08:07Z

src/Sylius/Bundle/OrderBundle/Resources/config/services.php

+    $services->set('sylius.custom_factory.adjustment', AdjustmentFactory::class)
+        ->private()
+        ->decorate('sylius.factory.adjustment', null, 256)
+        ->args([service('sylius.custom_factory.adjustment.inner')]);


Suggested change

->args([service('sylius.custom_factory.adjustment.inner')]);

->args([service('.inner')]);

crydotsnake requested review from a team as code owners January 31, 2026 10:53

crydotsnake force-pushed the xml2php/order branch from bd3504a to de72ecd Compare January 31, 2026 10:55

crydotsnake mentioned this pull request Jan 31, 2026

[Config] Convert XML to php in preparation of Symfony 8 #18490

Closed

25 tasks

crydotsnake force-pushed the xml2php/order branch from de72ecd to b3915da Compare January 31, 2026 12:45

TheMilek reviewed Feb 2, 2026

View reviewed changes

crydotsnake force-pushed the xml2php/order branch from b3915da to 77f3a0b Compare February 3, 2026 13:53

[XML2PHP] OrderBundle

b21bd06

crydotsnake force-pushed the xml2php/order branch from 77f3a0b to b21bd06 Compare February 4, 2026 08:28

TheMilek approved these changes Feb 4, 2026

View reviewed changes

TheMilek merged commit 2dc3adf into Sylius:2.3 Feb 4, 2026
65 of 67 checks passed

This was referenced Feb 4, 2026

[XML2PHP] PayumBundle #18768

Merged

[XML2PHP] PaymentBundle #18767

Merged

[XML2PHP] Channel #18496

Merged

[XML2PHP] Addressing #18491

Merged

[XML2PHP] Attribute #18495

Merged

[XML2PHP] Api #18493

Merged

coderabbitai bot mentioned this pull request Feb 20, 2026

[Behat] Update elements config from xml to php #18860

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[XML2PHP] OrderBundle#18766

[XML2PHP] OrderBundle#18766
TheMilek merged 1 commit intoSylius:2.3from
crydotsnake:xml2php/order

crydotsnake commented Jan 31, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 31, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

github-actions bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

TheMilek Feb 2, 2026

Uh oh!

TheMilek Feb 2, 2026

Uh oh!

TheMilek Feb 2, 2026

Uh oh!

TheMilek Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	->args([service('sylius.custom_factory.adjustment.inner')]);
	->args([service('.inner')]);

Uh oh!

Conversation

crydotsnake commented Jan 31, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

github-actions bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

Uh oh!

Uh oh!

TheMilek Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

TheMilek Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

TheMilek Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

TheMilek Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

crydotsnake commented Jan 31, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 31, 2026 •

edited

Loading

github-actions bot commented Jan 31, 2026 •

edited

Loading