Merged
Conversation
📝 WalkthroughWalkthroughThis pull request migrates Sylius MoneyBundle's service configuration from XML to PHP format. The services are moved from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
34498ac to
8fa91bb
Compare
25 tasks
8fa91bb to
fd3f410
Compare
TheMilek
previously approved these changes
Feb 2, 2026
src/Sylius/Bundle/MoneyBundle/Resources/config/services/integrations/currency.php
Outdated
Show resolved
Hide resolved
Rafikooo
reviewed
Feb 2, 2026
Comment on lines
+28
to
+30
| $services->set('sylius.formatter.money', MoneyFormatter::class); | ||
|
|
||
| $services->alias(MoneyFormatterInterface::class, 'sylius.formatter.money'); |
Contributor
There was a problem hiding this comment.
Suggested change
| $services->set('sylius.formatter.money', MoneyFormatter::class); | |
| $services->alias(MoneyFormatterInterface::class, 'sylius.formatter.money'); | |
| $services->set('sylius.formatter.money', MoneyFormatter::class); | |
| $services->alias(MoneyFormatterInterface::class, 'sylius.formatter.money'); |
For the sake of readability, please merge the service registration with its autowireable counterpart.
Comment on lines
+25
to
+26
| $services->set('sylius.form.type.money', MoneyType::class) | ||
| ->tag('form.type'); |
Contributor
There was a problem hiding this comment.
Suggested change
| $services->set('sylius.form.type.money', MoneyType::class) | |
| ->tag('form.type'); | |
| $services | |
| ->set('sylius.form.type.money', MoneyType::class) | |
| ->tag('form.type') | |
| ; | |
| or | |
| $services | |
| ->set('sylius.form.type.money', MoneyType::class) | |
| ->tag('form.type'); | |
Merged
fd3f410 to
7d85d47
Compare
TheMilek
approved these changes
Feb 4, 2026
This was referenced Feb 4, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit