Bump CI to `BuildTestAppAction@v4` by Rafikooo · Pull Request #18729 · Sylius/Sylius

Rafikooo · 2026-01-16T10:37:48Z

Testing new BuildTestAppAction from feature/auto-database-url branch which introduces:

Unified database format: mysql:8.4 instead of separate database + database_version
Automatic DATABASE_URL setting (no need to define in workflows)
Unified credentials (sylius:sylius@sylius) across all databases

Changes in this PR:

Update ci_e2e-mysql.yaml, ci_e2e-pgsql.yaml, ci_e2e-mariadb.yaml
Remove DATABASE_URL from env sections
Use new database: "type:version" format

Related: SyliusLabs/BuildTestAppAction#19

Summary by CodeRabbit

Chores
- CI workflows updated to use automated database configuration for MariaDB, MySQL, and PostgreSQL.
- Removed hard-coded database connection environment entries so jobs rely on generated configuration.
- Standardized database selection input across matrix jobs and updated build steps to a newer build-action for more consistent test runs.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-16T10:38:18Z

📝 Walkthrough

Walkthrough

Updated three CI/E2E GitHub Actions workflows to remove explicit DATABASE_URL env entries, bump SyliusLabs/BuildTestAppAction from v3.0.1 → v4, and replace database_version inputs with database inputs using matrix-based image tags (e.g., mysql:${{ matrix.mysql }}).

Changes

Cohort / File(s)	Summary
CI/E2E workflows `/.github/workflows/ci_e2e-mariadb.yaml`, `/.github/workflows/ci_e2e-mysql.yaml`, `/.github/workflows/ci_e2e-pgsql.yaml`	Removed hard-coded `DATABASE_URL` env entries in job envs; updated `SyliusLabs/BuildTestAppAction` usage from `v3.0.1` → `v4`; replaced `database_version` input with `database` input using matrix values (e.g., `database: "mysql:${{ matrix.mysql }}"`, `mariadb:${{ matrix.mariadb }}`, `postgres:${{ matrix.postgres }}`) and removed related `database_version` fields.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant GH as GitHub Actions Job
participant BTA as BuildTestAppAction (v4)
participant DB as Database Container (matrix image)
participant Steps as Subsequent Job Steps
GH->>BTA: invoke with database: name:${{ matrix.* }}
BTA->>DB: start container name:version
DB-->>BTA: expose connection details
BTA-->>GH: provide/generate DATABASE_URL env/output
GH->>Steps: subsequent steps consume generated DATABASE_URL

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

[Maintenance] GA fixes #18148 — Modifies BuildTestAppAction invocations in CI workflows (related action/input changes).
[CI] Bump BuildTestAppAction from v2.4 to 3.0.1 #18441 — Earlier update of BuildTestAppAction usage and inputs across e2e workflow files (related history of action/input changes).

Suggested reviewers

GSadee
TheMilek

Poem

🐰 I hopped through YAML with a clever grin,

Removed hard links, let matrix images in.
Build action hums and spins the DB song,
Connections bloom and tests march along. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately summarizes the main change: updating CI workflows to use BuildTestAppAction@v4, which is the primary modification across all three workflow files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-16T10:39:01Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)

.github/workflows/ci_e2e-mysql.yaml (1)

96-107: Pin BuildTestAppAction to a stable release and use consistent input format.

The feature branch ref @feature/auto-database-url is mutable and can break CI unexpectedly. Other workflows (ci_e2e-unstable.yaml, ci_frontend.yaml) use the stable @v3.0.1 which expects separate database and database_version inputs, not the combined database: "mysql:8.0" format used here. Align with the stable release once the auto-database-url feature is merged and released, or use the v3.0.1 input format (database: "mysql" + database_version: "...") in the meantime.

.github/workflows/ci_e2e-pgsql.yaml (1)

92-103: Pin BuildTestAppAction to an immutable ref.

Using a feature branch ref is mutable and poses a stability and security risk—it can change unexpectedly and break CI. Pin to a commit SHA or stable release tag instead. Verify that the target ref supports the new input parameters (database, php_version, etc.) before finalizing.

.github/workflows/ci_e2e-mariadb.yaml (1)

118-129: Pin BuildTestAppAction to a commit SHA until the feature branch is officially released.

Using feature/auto-database-url is mutable and can break CI unexpectedly if the branch is rebased or force-pushed. Since this new input format (database: "mariadb:${{ matrix.mariadb }}") is not yet in the stable v3.0.1 release, pin this ref to a specific commit SHA to prevent unintended changes. Once a release is published with the auto-database-url support, update to that stable release tag.

♻️ Duplicate comments (3)

.github/workflows/ci_e2e-pgsql.yaml (1)

179-190: Same concern as above (action pinning + input support).

.github/workflows/ci_e2e-mariadb.yaml (1)

231-242: Same concern as above (action pinning + input support).

.github/workflows/ci_e2e-mysql.yaml (1)

195-206: Same concern as above (action pinning + input support).

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84b970e and 240f7b3.

📒 Files selected for processing (3)

.github/workflows/ci_e2e-mariadb.yaml
.github/workflows/ci_e2e-mysql.yaml
.github/workflows/ci_e2e-pgsql.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Javascript Tests (MySQL) / Get matrix
GitHub Check: Packages / Get matrix
GitHub Check: Tests (MariaDB) / Get matrix
GitHub Check: Tests (PostgreSQL) / Get matrix
GitHub Check: Frontend / Get matrix

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

.github/workflows/ci_e2e-pgsql.yaml (1)

93-103: Pin action reference to a stable tag or commit SHA before merging to main.

Using @feature/auto-database-url branch reference is not suitable for the main branch. Feature branches can be force-pushed, rebased, or deleted, breaking CI reproducibility. Before merging to the 2.3 branch, update the SyliusLabs/BuildTestAppAction reference to either:

A versioned tag (e.g., @v4.0.0) once the upstream action PR is merged and released

A full commit SHA for immutability

The database: "postgres:${{ matrix.postgres }}" format change is correct. The matrix.postgres variable is properly defined in .github/workflows/matrix.json for both build types (minimal and full), and matches the pattern used in other workflows.

.github/workflows/ci_e2e-mariadb.yaml (1)

119-129: Replace @feature/auto-database-url with a stable tag or commit SHA before merging to 2.3.

The @feature/auto-database-url branch reference is unstable for production use. Other workflows in this repository (frontend, js, e2e-unstable) use the stable tag @v3.0.1. This applies to the pgsql and mysql workflows as well.

The database: "mariadb:${{ matrix.mariadb }}" format is correct and consistent with the pattern used in the pgsql and mysql workflows.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 240f7b3 and 3ffa60e.

📒 Files selected for processing (3)

.github/workflows/ci_e2e-mariadb.yaml
.github/workflows/ci_e2e-mysql.yaml
.github/workflows/ci_e2e-pgsql.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/ci_e2e-mysql.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Static checks / PHP 8.4, Symfony ~7.4.0

🔇 Additional comments (2)

.github/workflows/ci_e2e-pgsql.yaml (1)

180-190: Consistent with first occurrence – same stability note applies.

The changes here mirror the phpunit-cli-api job. The unified database format and removal of explicit DATABASE_URL are correctly applied.

.github/workflows/ci_e2e-mariadb.yaml (1)

232-242: Consistent with first occurrence in this file.

The behat-ui job correctly mirrors the changes from phpunit-cli-api. The unified database format is applied consistently.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Use new unified database format in e2e workflows: - database: "mysql:X.X" instead of database+database_version - database: "postgres:X.X" instead of postgresql+database_version - database: "mariadb:X.X" instead of mariadb+database_version - Remove DATABASE_URL from env (action sets it automatically)

Rafikooo requested review from a team as code owners January 16, 2026 10:37

probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jan 16, 2026

coderabbitai bot reviewed Jan 16, 2026

View reviewed changes

Rafikooo force-pushed the feature/test-build-action-v4 branch from 240f7b3 to 3ffa60e Compare January 16, 2026 13:57

coderabbitai bot reviewed Jan 16, 2026

View reviewed changes

Rafikooo force-pushed the feature/test-build-action-v4 branch from 3ffa60e to dc98fbb Compare January 16, 2026 17:03

Rafikooo force-pushed the feature/test-build-action-v4 branch from dc98fbb to 15f457e Compare January 27, 2026 14:02

Rafikooo changed the title ~~Test BuildTestAppAction v4 unified database format~~ Bump CI to BuildTestAppAction@v4 Jan 27, 2026

TheMilek approved these changes Jan 28, 2026

View reviewed changes

TheMilek merged commit fbfd6ad into Sylius:2.3 Jan 28, 2026
63 of 67 checks passed

This was referenced Feb 13, 2026

Upgrade BuildTestAppAction from v3.0.1 to v4 #18825

Merged

[UPMERGE] 2.2 -> 2.3 #18840

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump CI to `BuildTestAppAction@v4` #18729

Bump CI to `BuildTestAppAction@v4` #18729
TheMilek merged 1 commit intoSylius:2.3from
Rafikooo:feature/test-build-action-v4

Rafikooo commented Jan 16, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 16, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

github-actions bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Rafikooo commented Jan 16, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

github-actions bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rafikooo commented Jan 16, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 16, 2026 •

edited

Loading

github-actions bot commented Jan 16, 2026 •

edited

Loading