[CI] Bump BuildTestAppAction from v2.4 to 3.0.1#18441
Conversation
WalkthroughUpdated SyliusLabs/BuildTestAppAction usage across multiple CI workflows (v2.x → v3.0.1) and added Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
5297fe1 to
9a83e08
Compare
18b5bcf to
c37b49d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.github/workflows/ci_e2e-pgsql.yaml (1)
94-94: Verify that the commit hash aligns with BuildTestAppAction v3.0 and establish version pinning conventions.The action reference has been updated from
v2.4to a commit hash (65c9edc1f5170466e1edf33c149d6b219cc92532) instead of a semantic version tag (v3.0). While commit hashing provides reproducibility, it reduces clarity and maintainability compared to version tags.Please confirm:
- That this commit hash is the official v3.0 release
- Whether pinning to commit hashes (vs. version tags) is an established convention in this project's workflows
- If the PR title mentions "Bump to v3.0," the version tag approach would be more transparent and aligned with the PR description
(This observation will likely apply across all workflow files in this PR)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/ci_e2e-mariadb.yaml(1 hunks).github/workflows/ci_e2e-mysql.yaml(6 hunks).github/workflows/ci_e2e-pgsql.yaml(1 hunks).github/workflows/ci_e2e-unstable.yaml(5 hunks).github/workflows/ci_frontend.yaml(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- .github/workflows/ci_e2e-mariadb.yaml
- .github/workflows/ci_frontend.yaml
- .github/workflows/ci_e2e-unstable.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Static checks / PHP 8.4, Symfony ^7.3
🔇 Additional comments (1)
.github/workflows/ci_e2e-mysql.yaml (1)
98-98: Inconsistent coverage: PostgreSQL workflow missing OPcache parameter.The MySQL e2e_js jobs (lines 196, 287, 303) add the
opcache_enableparameter, but the PostgreSQL workflow (ci_e2e-pgsql.yaml, line 94) does not include this parameter in its corresponding job. The AI summary indicates changes were applied to multiple workflow files, but coverage appears incomplete.Verify that all e2e_js jobs across all workflow files (PostgreSQL, MariaDB, Unstable, Frontend) have consistent
opcache_enableconfiguration. If intentional, document why PostgreSQL is excluded.Also applies to: 196-196, 287-287, 303-303
dceab24 to
746c412
Compare
746c412 to
1e542d4
Compare
Summary
Summary by CodeRabbit