Skip to content

[CI] Bump BuildTestAppAction from v2.4 to 3.0.1#18441

Merged
GSadee merged 2 commits intoSylius:2.1from
Rafikooo:bump-build-test-app-action
Oct 20, 2025
Merged

[CI] Bump BuildTestAppAction from v2.4 to 3.0.1#18441
GSadee merged 2 commits intoSylius:2.1from
Rafikooo:bump-build-test-app-action

Conversation

@Rafikooo
Copy link
Copy Markdown
Contributor

@Rafikooo Rafikooo commented Oct 16, 2025

Summary

  • Updated all E2E workflow files (MariaDB, MySQL, PostgreSQL, Unstable, Frontend) to use BuildTestAppAction v3.0.1 instead of v2.4
  • Changed the server protocol for JS behats to HTTP

Summary by CodeRabbit

  • Chores
    • Updated CI build tooling to a fixed, updated action revision (v3.0.1) across frontend and end-to-end workflows for MySQL, MariaDB, PostgreSQL and unstable environments.
    • Added chrome_version: stable parameter in relevant MySQL end-to-end jobs.
    • Standardized test server config to use plain HTTP for local test runs (Behat base URL changed to http://127.0.0.1:8080/).

@Rafikooo Rafikooo requested review from a team as code owners October 16, 2025 12:42
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Oct 16, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 16, 2025

Walkthrough

Updated SyliusLabs/BuildTestAppAction usage across multiple CI workflows (v2.x → v3.0.1) and added chrome_version: stable in some MySQL Panther/Full invocations; changed Behat MinkExtension base_url from https://127.0.0.1:8080/ to http://127.0.0.1:8080/.

Changes

Cohort / File(s) Summary
E2E — MariaDB
​.github/workflows/ci_e2e-mariadb.yaml
Bumped SyliusLabs/BuildTestAppAction from v2.4 to v3.0.1; no other inputs changed.
E2E — MySQL
​.github/workflows/ci_e2e-mysql.yaml
Replaced BuildTestAppAction refs (previously v2.3/v2.4) with v3.0.1; added chrome_version: stable to some Panther/Full action calls; other inputs unchanged.
E2E — PostgreSQL
​.github/workflows/ci_e2e-pgsql.yaml
Updated BuildTestAppAction invocation from v2.4 to v3.0.1; no other changes.
E2E — Unstable
​.github/workflows/ci_e2e-unstable.yaml
Switched BuildTestAppAction refs in three "Build application" steps to v3.0.1; other parameters unchanged.
Frontend
​.github/workflows/ci_frontend.yaml
Updated SyliusLabs/BuildTestAppAction from v2.4 to v3.0.1; no other inputs changed.
Behat config (base URL)
behat.yml.dist
Changed MinkExtension base_url from https://127.0.0.1:8080/ to http://127.0.0.1:8080/.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Dependencies

Suggested reviewers

  • GSadee
  • loic425
  • mpysiak

Poem

🐇 I hopped through YAML with tiny paws,
Bumped versions, tweaked a few small laws.
Swapped HTTPS to HTTP for the local door,
Set Chrome to "stable", then hopped off some more.
🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "[CI] Bump BuildTestAppAction from v2.4 to 3.0.1" directly and clearly describes the primary change in the changeset. The vast majority of the modifications across five workflow files (ci_e2e-mariadb.yaml, ci_e2e-mysql.yaml, ci_e2e-pgsql.yaml, ci_e2e-unstable.yaml, and ci_frontend.yaml) involve upgrading the BuildTestAppAction version from v2.4 to v3.0.1. The title is concise, specific, and leaves no ambiguity about what dependency is being updated and the version range involved. While the changeset includes a secondary modification to behat.yml.dist (changing base_url protocol), this does not detract from the title's accuracy since PR titles are expected to highlight the primary change rather than enumerate every detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 746c412 and 1e542d4.

📒 Files selected for processing (6)
  • .github/workflows/ci_e2e-mariadb.yaml (1 hunks)
  • .github/workflows/ci_e2e-mysql.yaml (4 hunks)
  • .github/workflows/ci_e2e-pgsql.yaml (1 hunks)
  • .github/workflows/ci_e2e-unstable.yaml (3 hunks)
  • .github/workflows/ci_frontend.yaml (1 hunks)
  • behat.yml.dist (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .github/workflows/ci_e2e-mariadb.yaml
  • .github/workflows/ci_frontend.yaml
  • .github/workflows/ci_e2e-pgsql.yaml
  • .github/workflows/ci_e2e-mysql.yaml
  • behat.yml.dist
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Static checks / PHP 8.4, Symfony ^7.3
  • GitHub Check: Static checks / PHP 8.3, Symfony ^6.4
🔇 Additional comments (2)
.github/workflows/ci_e2e-unstable.yaml (2)

56-56: Verify BuildTestAppAction v3.0.1 compatibility with existing workflow parameters.

The action is upgraded from v2.4 to v3.0.1 across all three build steps. Since this is a major version bump, confirm:

  1. Whether v3.0.1 introduces any breaking changes requiring parameter adjustments
  2. Whether the existing build_type, cache_key, e2e, and other parameters remain compatible
  3. Whether these changes have been tested in your environment

Also applies to: 136-136, 217-217


229-229: Clarify the selective addition of chrome_version: stable.

Line 229 adds chrome_version: stable to the Panther step, but the Chromedriver step (line 136) does not include this parameter. Confirm:

  1. Whether this parameter is a new requirement in v3.0.1 for Panther but not Chromedriver
  2. Whether Chromedriver should also have this parameter or if the action defaults appropriately
  3. Whether this aligns with the broader PR changes across other workflow files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@Rafikooo Rafikooo force-pushed the bump-build-test-app-action branch 2 times, most recently from 5297fe1 to 9a83e08 Compare October 16, 2025 12:56
@Rafikooo Rafikooo closed this Oct 16, 2025
@Rafikooo Rafikooo reopened this Oct 16, 2025
@Rafikooo Rafikooo force-pushed the bump-build-test-app-action branch 2 times, most recently from 18b5bcf to c37b49d Compare October 18, 2025 14:00
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
.github/workflows/ci_e2e-pgsql.yaml (1)

94-94: Verify that the commit hash aligns with BuildTestAppAction v3.0 and establish version pinning conventions.

The action reference has been updated from v2.4 to a commit hash (65c9edc1f5170466e1edf33c149d6b219cc92532) instead of a semantic version tag (v3.0). While commit hashing provides reproducibility, it reduces clarity and maintainability compared to version tags.

Please confirm:

  1. That this commit hash is the official v3.0 release
  2. Whether pinning to commit hashes (vs. version tags) is an established convention in this project's workflows
  3. If the PR title mentions "Bump to v3.0," the version tag approach would be more transparent and aligned with the PR description

(This observation will likely apply across all workflow files in this PR)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e4bd17 and c943dfc.

📒 Files selected for processing (5)
  • .github/workflows/ci_e2e-mariadb.yaml (1 hunks)
  • .github/workflows/ci_e2e-mysql.yaml (6 hunks)
  • .github/workflows/ci_e2e-pgsql.yaml (1 hunks)
  • .github/workflows/ci_e2e-unstable.yaml (5 hunks)
  • .github/workflows/ci_frontend.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/workflows/ci_e2e-mariadb.yaml
  • .github/workflows/ci_frontend.yaml
  • .github/workflows/ci_e2e-unstable.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Static checks / PHP 8.4, Symfony ^7.3
🔇 Additional comments (1)
.github/workflows/ci_e2e-mysql.yaml (1)

98-98: Inconsistent coverage: PostgreSQL workflow missing OPcache parameter.

The MySQL e2e_js jobs (lines 196, 287, 303) add the opcache_enable parameter, but the PostgreSQL workflow (ci_e2e-pgsql.yaml, line 94) does not include this parameter in its corresponding job. The AI summary indicates changes were applied to multiple workflow files, but coverage appears incomplete.

Verify that all e2e_js jobs across all workflow files (PostgreSQL, MariaDB, Unstable, Frontend) have consistent opcache_enable configuration. If intentional, document why PostgreSQL is excluded.

Also applies to: 196-196, 287-287, 303-303

@Rafikooo Rafikooo force-pushed the bump-build-test-app-action branch 3 times, most recently from dceab24 to 746c412 Compare October 20, 2025 11:30
@Rafikooo Rafikooo changed the title [CI] Bump BuildTestAppAction from v2.4 to 3.0 [CI] Bump BuildTestAppAction from v2.4 to 3.0.1 Oct 20, 2025
@Rafikooo Rafikooo force-pushed the bump-build-test-app-action branch from 746c412 to 1e542d4 Compare October 20, 2025 11:36
@GSadee GSadee merged commit b333551 into Sylius:2.1 Oct 20, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants