.github/workflows/ci_e2e-unstable.yaml (1)

3-11: ⚠️ Potential issue

Define branch input under both triggers
The workflow references inputs.branch in several jobs, but neither workflow_call nor workflow_dispatch declares a branch input. This will lead to undefined values at runtime. Please add a branch input with a default (e.g., empty string) under both triggers:

on:
  workflow_call:
    inputs:
      ignore-failure:
        description: "Don't fail on error"
        required: false
        type: boolean
        default: false
      branch:
        description: "Git branch to checkout"
        required: false
        type: string
        default: ""
  workflow_dispatch:
    inputs:
      branch:
        description: "Git branch to checkout"
        required: false
        default: ""

.github/workflows/ci_e2e-unstable.yaml (1)

91-245: Consider DRY’ing duplicated job definitions
The two JS jobs (chromedriver and panther) share nearly identical steps. To reduce maintenance overhead, you could extract common steps into YAML anchors or a reusable composite action, parameterizing only the differences (e.g., e2e_js, chrome_version).

# Example using an anchor for shared steps
.shared-steps: &shared-build
  - name: Get Composer cache directory
    id: composer-cache
    run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
  - name: Restore dependencies
    uses: actions/cache@v4
    with:
      path: ${{ steps.composer-cache.outputs.dir }}
      key: ...
  - name: Change minimum-stability to dev
    run: |
      composer config minimum-stability dev
      composer config prefer-stable true
  - name: Build application
    uses: SyliusLabs/BuildTestAppAction@v2.4
    with:
      # shared parameters...

Then reference <<: *shared-build in each job before job-specific steps.

🧰 Tools

🪛 actionlint (1.7.7)

93-93: property "env" is not defined in object type {mysql: number; php: number; symfony: string}

(expression)

---

105-105: property "env" is not defined in object type {mysql: number; php: number; symfony: string}

(expression)

---

110-110: property "branch" is not defined in object type {ignore-failure: bool}

(expression)

---

113-113: property "branch" is not defined in object type {ignore-failure: bool}

(expression)

---

116-116: property "branch" is not defined in object type {ignore-failure: bool}

(expression)

---

175-175: property "env" is not defined in object type {mysql: number; php: number; symfony: string}

(expression)

---

187-187: property "env" is not defined in object type {mysql: number; php: number; symfony: string}

(expression)

---

192-192: property "branch" is not defined in object type {ignore-failure: bool}

(expression)

---

195-195: property "branch" is not defined in object type {ignore-failure: bool}

(expression)

---

198-198: property "branch" is not defined in object type {ignore-failure: bool}

(expression)

🪛 YAMLlint (1.37.1)

[warning] 109-109: too many spaces after hyphen

(hyphens)

---

[warning] 115-115: too many spaces after hyphen

(hyphens)

---

[warning] 119-119: too many spaces after hyphen

(hyphens)

---

[warning] 123-123: too many spaces after hyphen

(hyphens)

---

[warning] 130-130: too many spaces after hyphen

(hyphens)

---

[warning] 135-135: too many spaces after hyphen

(hyphens)

---

[warning] 149-149: too many spaces after hyphen

(hyphens)

---

[warning] 155-155: too many spaces after hyphen

(hyphens)

---

[warning] 162-162: too many spaces after hyphen

(hyphens)

---

[warning] 191-191: too many spaces after hyphen

(hyphens)

---

[warning] 197-197: too many spaces after hyphen

(hyphens)

---

[warning] 201-201: too many spaces after hyphen

(hyphens)

---

[warning] 205-205: too many spaces after hyphen

(hyphens)

---

[warning] 212-212: too many spaces after hyphen

(hyphens)

---

[warning] 217-217: too many spaces after hyphen

(hyphens)

---

[warning] 232-232: too many spaces after hyphen

(hyphens)

---

[warning] 235-235: too many spaces after hyphen

(hyphens)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro