Remove 2.0 branch references from CI workflows by Rafikooo · Pull Request #18608 · Sylius/Sylius

Rafikooo · 2025-11-30T13:42:20Z

Q	A
Branch?	2.1
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	-
License	MIT

With the 2.0 branch reaching end of support, this removes references to it from CI workflows and updates the PR template guidance accordingly.

Remove Node.js version detection for 2.0 branch in e2e workflows
Update PHPSpec condition to only run on 1.14
Update refactor workflow matrix to target 2.1 and 2.2 instead of 2.0 and 2.1
Update PR template to reflect new branch targets

Summary by CodeRabbit

Chores
- Updated development and release guidance in project templates to reflect current branch targeting strategies.
- Simplified CI/CD workflow configurations by streamlining build environment handling across multiple test pipelines.
- Updated test execution conditions to optimize continuous integration processes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-11-30T13:42:43Z

Walkthrough

This PR removes GitHub Actions CI workflow support for branch 2.0 and updates PR template guidance to target branches 1.14/2.1 for bug fixes and 2.2 for features. Node.js version conditionals for branch 2.0 are removed across multiple e2e workflows, PHPSpec execution is restricted to branch 1.14, and the refactor workflow matrix is updated to target 2.1 and 2.2.

Changes

Cohort / File(s)	Summary
PR Template Guidance `.github/PULL_REQUEST_TEMPLATE.md`	Updated base branch targeting: bug fixes now target 1.14 or 2.1 (was 1.14 or 2.0); features and deprecations now target 2.2 (was 2.1)
E2E Workflow Node.js Versioning `.github/workflows/ci_e2e-mariadb.yaml`, `.github/workflows/ci_e2e-mysql.yaml`, `.github/workflows/ci_e2e-pgsql.yaml`	Removed conditional branches that set NODE_VERSION to 22.x for branch 2.0; logic now only handles branch 1.14 (20.x) with fallback to 24.x for all others
Static Checks Workflow `.github/workflows/ci_static-checks.yaml`	Changed PHPSpec step execution condition from branches '1.14' or '2.0' to only '1.14'; branch 2.0 now skips PHPSpec
Refactor Workflow Matrix `.github/workflows/refactor.yaml`	Updated matrix entries: replaced branch 2.0 → 2.1 mapping and branch 2.1 → 2.2 mapping; adjusted PR base branch targeting accordingly

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Multiple files follow a consistent pattern of removing 2.0 branch conditionals with straightforward logic updates
Branch matrix and condition changes are localized and self-evident
No complex control flow or business logic introduced

Possibly related PRs

#18431: Removes 2.0 branch special handling from CI workflows and updates target branches to 2.1/2.2
#18389: Updates PR template branch guidance and CI workflow branch targeting, sharing overlap with this PR's template and matrix changes
#18148: Modifies Node.js version branching logic in the same e2e workflow files

Suggested reviewers

GSadee
mpysiak

Poem

🐰 Branch 2.0 hops away into the distant past,
While 2.1 and 2.2 take center stage at last!
Node versions shift with purpose clear and bright,
PHPSpec focuses where it's needed right.
The workflows trim their branches, lean and neat—
Updates march on, making CI complete! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing 2.0 branch references from CI workflows. It is concise, specific, and clearly reflects the primary objective of the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed16d2e and 9f52c7b.

📒 Files selected for processing (6)

.github/PULL_REQUEST_TEMPLATE.md (1 hunks)
.github/workflows/ci_e2e-mariadb.yaml (0 hunks)
.github/workflows/ci_e2e-mysql.yaml (0 hunks)
.github/workflows/ci_e2e-pgsql.yaml (0 hunks)
.github/workflows/ci_static-checks.yaml (1 hunks)
.github/workflows/refactor.yaml (1 hunks)

💤 Files with no reviewable changes (3)

.github/workflows/ci_e2e-mariadb.yaml
.github/workflows/ci_e2e-mysql.yaml
.github/workflows/ci_e2e-pgsql.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Static checks / PHP 8.4, Symfony ~7.3.0

🔇 Additional comments (2)

.github/workflows/ci_static-checks.yaml (1)

125-127: PHPSpec condition correctly restricted to branch 1.14.

The change appropriately removes 2.0 from the conditional, aligning with its end-of-support status. PHPSpec will now only execute on the 1.14 branch.

.github/workflows/refactor.yaml (1)

27-35: Matrix correctly updated to target 2.1 and 2.2.

The refactor workflow now targets currently supported branches (2.1 and 2.2) instead of EOL branch 2.0. The 1.14 entry with PHP 8.1 remains unchanged for maintenance builds.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-11-30T13:43:34Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

[CI] Remove 2.0 branch references from workflows

9f52c7b

Rafikooo requested review from a team as code owners November 30, 2025 13:42

probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Nov 30, 2025

Wojdylak approved these changes Dec 1, 2025

View reviewed changes

Wojdylak merged commit 803f27f into Sylius:2.1 Dec 1, 2025
27 checks passed

This was referenced Dec 3, 2025

[CI] Split Chromedriver tests into parallel jobs #18603

Merged

[CI] Remove pull_request trigger from full CI workflows #18626

Merged

coderabbitai bot mentioned this pull request Dec 19, 2025

[CI] Standardize job timeouts to 15 minutes #18693

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove 2.0 branch references from CI workflows#18608

Remove 2.0 branch references from CI workflows#18608
Wojdylak merged 1 commit intoSylius:2.1from
Rafikooo:ci/remove-2.0-branch-references

Rafikooo commented Nov 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Nov 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Rafikooo commented Nov 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rafikooo commented Nov 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 30, 2025 •

edited

Loading

github-actions bot commented Nov 30, 2025 •

edited

Loading