src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/order.php-1-5 (1)

1-5: ⚠️ Potential issue | 🟡 Minor

Missing declare(strict_types=1); and return type on closure.

As per coding guidelines, all PHP files must declare strict_types=1 and include type declarations for return values.

Proposed fix

 <?php
 
+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {
     $services = $container->services();

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/customer.php-1-3 (1)

1-3: ⚠️ Potential issue | 🟡 Minor

Missing declare(strict_types=1); statement.

As per coding guidelines, declare strict_types=1 at the beginning of all PHP files.

Proposed fix

 <?php
 
+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/product_variant.php-1-5 (1)

1-5: ⚠️ Potential issue | 🟡 Minor

Add strict types and a closure return type.

Line 1 is missing declare(strict_types=1);, and Line 5 should declare a return type for the configurator closure.

Proposed fix

 <?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines, “Declare strict_types=1 at the beginning of all PHP files” and “Add type declarations for all properties, arguments, and return values in PHP code.”

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/shipment.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict_types and a void return type for the configurator closure.

This aligns the file with PHP typing rules and keeps the closure contract explicit.

💡 Proposed fix

-<?php
+<?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {
     $services = $container->services();

As per coding guidelines, Declare strict_types=1 at the beginning of all PHP files and Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/shipment.php-8-14 (1)

8-14: ⚠️ Potential issue | 🟡 Minor

Use class constants with use imports instead of string FQCNs.

This keeps references refactor-safe and matches the repo’s PHP style.

💡 Proposed fix

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

+use Sylius\Bundle\AdminBundle\Form\Type\ShipmentShipType;
+use Sylius\Bundle\AdminBundle\Twig\Component\Shipment\ShipFormComponent;
 
 return static function (ContainerConfigurator $container): void {
     $services = $container->services();

-    $services->set('sylius_admin.twig.component.shipment.ship_form', 'Sylius\Bundle\AdminBundle\Twig\Component\Shipment\ShipFormComponent')
+    $services->set('sylius_admin.twig.component.shipment.ship_form', ShipFormComponent::class)
         ->args([
             service('sylius.repository.shipment'),
             service('form.factory'),
             '%sylius.model.shipment.class%',
-            'Sylius\Bundle\AdminBundle\Form\Type\ShipmentShipType',
+            ShipmentShipType::class,
         ])
         ->tag('sylius.live_component.admin', ['key' => 'sylius_admin:shipment:ship_form']);
 };

As per coding guidelines, Use use statements for all non-global classes in PHP.

src/Sylius/Bundle/AdminBundle/Resources/config/services/form.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add declare(strict_types=1) to the file.

Line 1 should declare strict types per the coding guidelines. This is already being applied across other config files in the codebase (88 similar files already have this declaration).

Proposed fix

 <?php
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/product_attribute.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add declare(strict_types=1); at the beginning of the file.

Line 1 should include the strict types declaration per the coding guidelines. This aligns with the pattern adopted in other bundles like PayumBundle and UiBundle.

Proposed fix

 <?php
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
 return static function(ContainerConfigurator $container) {

Note: Return type declarations on service config closures are not used elsewhere in the codebase, so that portion of the original suggestion should be omitted.

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/product_option.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and a void return type to the config closure.

This file is missing declare(strict_types=1); and the closure lacks an explicit : void return type, both required by the coding guidelines.

🔧 Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
-return static function(ContainerConfigurator $container) {
+return static function(ContainerConfigurator $container): void {

src/Sylius/Bundle/AdminBundle/Resources/config/services/email.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add declare(strict_types=1) and explicit return type to the configurator closure.

The file is missing the declare(strict_types=1); statement at the beginning and the closure lacks an explicit : void return type, both required by the PHP coding guidelines.

🔧 Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
-return static function(ContainerConfigurator $container) {
+return static function(ContainerConfigurator $container): void {

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/product.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add declare(strict_types=1); and : void return type to the config closure.

This file is missing the strict types declaration and the configurator closure lacks an explicit return type, both required by the coding guidelines.

🔧 Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
-return static function(ContainerConfigurator $container) {
+return static function(ContainerConfigurator $container): void {

src/Sylius/Bundle/AdminBundle/Resources/config/services/product/form.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add declare(strict_types=1); to the file.

This config file is missing the required declare(strict_types=1); declaration at the beginning. Other DI config files in the codebase include this declaration after the opening <?php tag and before the namespace.

🔧 Proposed fix

 <?php
 
+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

As per coding guidelines: "Declare strict_types=1 at the beginning of all PHP files".

src/Sylius/Bundle/AdminBundle/Resources/config/services/grid.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and void return type to the config closure.

This file is missing declare(strict_types=1); at the top and the configurator closure lacks an explicit : void return type, both required by the coding guidelines and Symfony PHP configuration standards.

🔧 Proposed fix

 <?php
+
+declare(strict_types=1);
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
-return static function(ContainerConfigurator $container) {
+return static function(ContainerConfigurator $container): void {

Per coding guidelines: "Declare strict_types=1 at the beginning of all PHP files" and "Add type declarations for all properties, arguments, and return values in PHP code".

src/Sylius/Bundle/AdminBundle/Resources/config/services/integrations/shop.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and a void return type to the config closure.

🛠️ Proposed fix

 <?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/dashboard.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and a void return type to the config closure.

🛠️ Proposed fix

 <?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/dashboard/pending_action.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and a void return type to the config closure.

🛠️ Proposed fix

 <?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/AdminBundle/Resources/config/services/notification.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and a void return type to the config closure.

🛠️ Proposed fix

 <?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/AdminBundle/Resources/config/services/controller.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and a void return type to the config closure.

🛠️ Proposed fix

 <?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/AdminBundle/Resources/config/services/listener.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and a void return type to the config closure.

🛠️ Proposed fix

 <?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/AdminBundle/Resources/config/services/pending_action.php-1-6 (1)

1-6: ⚠️ Potential issue | 🟡 Minor

Add strict types and a void return type to the config closure.

🛠️ Proposed fix

 <?php
+declare(strict_types=1);

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

-return static function(ContainerConfigurator $container) {
+return static function (ContainerConfigurator $container): void {

As per coding guidelines: Declare strict_types=1 at the beginning of all PHP files; Add type declarations for all properties, arguments, and return values in PHP code.

src/Sylius/Bundle/AdminBundle/Resources/config/services.php-1-3 (1)

1-3: ⚠️ Potential issue | 🟡 Minor

Missing declare(strict_types=1); statement.

Per coding guidelines, all PHP files should declare strict types at the beginning.

Proposed fix

 <?php
 
+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component.php-1-3 (1)

1-3: ⚠️ Potential issue | 🟡 Minor

Missing declare(strict_types=1); statement.

Per coding guidelines, all PHP files should declare strict types at the beginning.

Proposed fix

 <?php
 
+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/customer.php (1)

8-8: Consider using ::class constant for the service class.

Using the ::class constant with a use statement improves IDE support, enables better refactoring, and catches typos at static analysis time.

Proposed refactor

 <?php
 
+declare(strict_types=1);
+
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
+use Sylius\Bundle\AdminBundle\Twig\Component\Customer\OrderStatisticsComponent;
+
 return static function(ContainerConfigurator $container) {
     $services = $container->services();
 
-    $services->set('sylius_admin.twig.component.customer.order_statistics', 'Sylius\Bundle\AdminBundle\Twig\Component\Customer\OrderStatisticsComponent')
+    $services->set('sylius_admin.twig.component.customer.order_statistics', OrderStatisticsComponent::class)
         ->args([
             service('sylius.repository.customer'),
             service('sylius.provider.statistics.customer'),
         ])
         ->tag('sylius.live_component.admin', ['key' => 'sylius_admin:customer:order_statistics']);
 };

src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component/promotion_coupon.php (1)

8-21: Use ::class constants with imports instead of string FQCNs.

This aligns with the guideline to use imports and modern PHP class references.

♻️ Proposed refactor

 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
+use Sylius\Bundle\AdminBundle\Form\Type\PromotionCouponGeneratorInstructionType;
+use Sylius\Bundle\AdminBundle\Form\Type\PromotionCouponType;
+use Sylius\Bundle\AdminBundle\Twig\Component\PromotionCoupon\GeneratorInstructionFormComponent;
+use Sylius\Bundle\UiBundle\Twig\Component\ResourceFormComponent;
+
 return static function (ContainerConfigurator $container): void {
     $services = $container->services();
 
-    $services->set('sylius_admin.twig.component.promotion_coupon.form', 'Sylius\Bundle\UiBundle\Twig\Component\ResourceFormComponent')
+    $services->set('sylius_admin.twig.component.promotion_coupon.form', ResourceFormComponent::class)
         ->args([
             service('sylius.repository.promotion_coupon'),
             service('form.factory'),
             '%sylius.model.promotion_coupon.class%',
-            'Sylius\Bundle\AdminBundle\Form\Type\PromotionCouponType',
+            PromotionCouponType::class,
         ])
         ->tag('sylius.live_component.admin', ['key' => 'sylius_admin:promotion_coupon:form']);
 
-    $services->set('sylius_admin.twig.component.promotion_coupon.generator_instruction_form', 'Sylius\Bundle\AdminBundle\Twig\Component\PromotionCoupon\GeneratorInstructionFormComponent')
+    $services->set('sylius_admin.twig.component.promotion_coupon.generator_instruction_form', GeneratorInstructionFormComponent::class)
         ->args([
             service('form.factory'),
-            '\Sylius\Bundle\AdminBundle\Form\Type\PromotionCouponGeneratorInstructionType',
+            PromotionCouponGeneratorInstructionType::class,
         ])
         ->tag('sylius.live_component.admin', ['key' => 'sylius_admin:promotion_coupon:generator_instruction_form']);
 };

As per coding guidelines: "Use use statements for all non-global classes in PHP" and "Use modern PHP 8.2+ syntax and features".

src/Sylius/Bundle/AdminBundle/Resources/config/services.php (2)

80-80: Consider using FQCN import + ::class for the alias target.

Line 80 uses a raw string 'Psr\Http\Client\ClientInterface' instead of importing the class and using ClientInterface::class. While functionally equivalent, using ::class references is more consistent with the rest of this file and provides IDE navigation and static analysis benefits.

♻️ Suggested change

Add to the imports:

use Psr\Http\Client\ClientInterface;

Then update the alias:

-    $services->alias('sylius.http_client', 'Psr\Http\Client\ClientInterface');
+    $services->alias('sylius.http_client', ClientInterface::class);

---

80-80: Consider using ::class constant instead of a raw string for the alias target.

Line 80 uses 'Psr\Http\Client\ClientInterface' as a raw string, while all other class references in this file use imported ::class constants. Using ::class is more consistent and provides IDE navigation and static analysis benefits.

♻️ Suggested change

Add to the imports:

use Psr\Http\Client\ClientInterface;

-    $services->alias('sylius.http_client', 'Psr\Http\Client\ClientInterface');
+    $services->alias('sylius.http_client', ClientInterface::class);