Skip to content

[XML2PHP] TaxationBundle#18774

Merged
TheMilek merged 1 commit intoSylius:2.3from
crydotsnake:xml2php/taxation
Feb 4, 2026
Merged

[XML2PHP] TaxationBundle#18774
TheMilek merged 1 commit intoSylius:2.3from
crydotsnake:xml2php/taxation

Conversation

@crydotsnake
Copy link
Copy Markdown
Member

@crydotsnake crydotsnake commented Jan 31, 2026

Q A
Branch? 2.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially #18490
License MIT

Summary by CodeRabbit

  • Refactor
    • Modernized service configuration by migrating from XML-based to PHP-based format for the TaxationBundle. This improves code maintainability and consistency across the codebase while preserving all existing functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@crydotsnake crydotsnake requested review from a team as code owners January 31, 2026 13:00
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 31, 2026

Warning

Rate limit exceeded

@crydotsnake has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

The TaxationBundle's Symfony service configuration is migrated from XML to PHP format. The DependencyInjection extension is updated to use PhpFileLoader instead of XmlFileLoader, and corresponding PHP configuration files replace their XML counterparts with equivalent service definitions and wiring. Additionally, a symbol is whitelisted in the composer-require-checker configuration.

Changes

Cohort / File(s) Summary
Configuration Migration
src/Sylius/Bundle/TaxationBundle/DependencyInjection/SyliusTaxationExtension.php
Updated loader from XmlFileLoader to PhpFileLoader and adjusted resource paths from .xml to .php for service configuration files.
PHP Service Definitions
src/Sylius/Bundle/TaxationBundle/Resources/config/services.php, src/Sylius/Bundle/TaxationBundle/Resources/config/services/form.php, src/Sylius/Bundle/TaxationBundle/Resources/config/services/integrations/doctrine/orm.php
New PHP-based Symfony DI configuration files replacing XML equivalents. Define service registrations, aliases, tags, and dependencies for tax calculators, rate resolution, form types, and repository mappings.
Removed XML Configurations
src/Sylius/Bundle/TaxationBundle/Resources/config/services.xml, src/Sylius/Bundle/TaxationBundle/Resources/config/services/form.xml, src/Sylius/Bundle/TaxationBundle/Resources/config/services/integrations/doctrine/orm.xml
XML service configuration files deleted after migration to PHP format.
Composer Checker Whitelist
composer-require-checker.json
Added "service" symbol to the symbol-whitelist array.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

DX, Maintenance

Suggested reviewers

  • GSadee
  • diimpp

Poem

🐰 From XML to PHP we hop,
Configuration files migrate non-stop,
Services dance in a modern way,
The bundle leaps brighter today! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[XML2PHP] TaxationBundle' accurately reflects the main change: converting TaxationBundle service configuration from XML to PHP format across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2026

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

Comment on lines +27 to +29
$services = $container->services();
$parameters = $container->parameters();
$container->import('services/form.php');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$services = $container->services();
$parameters = $container->parameters();
$container->import('services/form.php');
$container->import('services/form.php');
$services = $container->services();
$parameters = $container->parameters();

@TheMilek TheMilek merged commit fc705f1 into Sylius:2.3 Feb 4, 2026
65 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants