[Shop] Image/File Uploud Buttons Size Fix by PiotrTulacz · Pull Request #18286 · Sylius/Sylius

PiotrTulacz · 2025-07-31T22:08:04Z

Before:

After:
>

Summary by CodeRabbit

Style
- Enhanced file input buttons to have a consistent minimum height with other form controls for improved visual alignment.

coderabbitai · 2025-07-31T22:08:12Z

Walkthrough

A new CSS rule was added targeting the ::file-selector-button pseudo-element of input[type="file"].form-control, setting its min-height to 44px to match the minimum height of other form controls. No other style properties or selectors were changed.

Changes

Cohort / File(s)	Change Summary
Form File Input Button Height Adjustment `src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_form.scss`	Added a CSS rule setting `min-height: 44px` on `input[type="file"].form-control::file-selector-button` to align button height with other form controls.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

UX, Shop, Frontend

Suggested reviewers

GSadee

Poem

A bunny hopped through fields of code,
With CSS tweaks in gentle mode.
File inputs now stand just right,
Their buttons tall, a pleasing sight.
So let us cheer this tiny feat—
For every form, a perfect seat! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ba1459 and 5a7f622.

📒 Files selected for processing (1)

src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_form.scss (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_form.scss

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Static checks / PHP 8.2, Symfony ^6.4
GitHub Check: Static checks / PHP 8.3, Symfony ^7.2
GitHub Check: Static checks / PHP 8.4, Symfony ^7.2

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-31T22:09:29Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_form.scss (1)
58-64: Nest the override to keep related rules together

Placing the file-specific override immediately after – but visually separate from – the generic .form-control rule makes maintenance harder.
Consider nesting the attribute selector inside the existing block so future refactors don’t miss the coupling.
-.form-control[type="file"] {
-    min-height: unset;
-}
+.form-control {
+    // File inputs should keep their native height
+    &[type="file"] {
+        min-height: unset;
+    }
+}
This keeps all .form-control height logic in one place without changing specificity or output.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 593e209 and 3ba1459.

📒 Files selected for processing (1)

src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_form.scss (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Static checks / PHP 8.4, Symfony ^7.2
GitHub Check: Static checks / PHP 8.3, Symfony ^7.2
GitHub Check: Static checks / PHP 8.2, Symfony ^6.4

🔇 Additional comments (1)

src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_form.scss (1)

62-64: Verify unset meets browser support matrix

min-height: unset is fine for evergreen browsers, but older Safari (< 14) and legacy Edge versions treat unset inconsistently. If those are still in your supported matrix, fallback to initial or auto, or add a comment confirming they’re out of scope.

| Q | A |-----------------|----- | Branch? | 2.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | – | License | MIT ### Summary Fix four obvious typos in `CHANGELOG-2.1.md`: - `Uploud` → `Upload` (v2.1.5, PR #18286) - `confflict` → `conflict` (v2.1.5, PR #18302) - `nessecary` → `necessary` (v2.1.5, PR #18342) - `lables` → `labels` (v2.1.2, PR #18180) ### Notes - Minimal diffs only; no punctuation/style changes. - Code, identifiers, and formatting are untouched.  ## Summary by CodeRabbit * **Documentation** * Corrected typos in changelog entries for improved readability and clarity.

fix button

3ba1459

PiotrTulacz requested review from a team as code owners July 31, 2025 22:08

coderabbitai bot reviewed Jul 31, 2025

View reviewed changes

fix button

5a7f622

PiotrTulacz mentioned this pull request Jul 31, 2025

Fix #18228 : Fix issue with file input field on Chrome #18229

Closed

dobralin mentioned this pull request Aug 5, 2025

Automated cloud preview environments at Pull Request magento/magento2#37518

Open

5 tasks

TheMilek approved these changes Aug 12, 2025

View reviewed changes

TheMilek merged commit ee1c50a into Sylius:2.1 Aug 12, 2025
55 of 57 checks passed

TheMilek mentioned this pull request Aug 12, 2025

File field height issue on Chrome #18228

Closed

alisolphp mentioned this pull request Oct 20, 2025

[Changelog] Fix obvious typos in 2.1 changelog #18461

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Shop] Image/File Uploud Buttons Size Fix#18286

[Shop] Image/File Uploud Buttons Size Fix#18286
TheMilek merged 2 commits intoSylius:2.1from
PiotrTulacz:Uploud-buttons-size

PiotrTulacz commented Jul 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

PiotrTulacz commented Jul 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PiotrTulacz commented Jul 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jul 31, 2025 •

edited

Loading