[New routing] Admin customers crud by loic425 · Pull Request #18239 · Sylius/Sylius

loic425 · 2025-07-18T13:01:02Z

Q	A
Branch?	new-routing
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	partially #18212
License	MIT

Summary by CodeRabbit

New Features
- Introduced advanced routing configuration options, allowing fine-grained control over backward compatibility layers for admin routes.
- Added new admin resource configurations for user, catalog promotion, channel, country, customer, and product management, enabling enhanced CRUD and bulk operations in the admin interface.
Bug Fixes
- Improved route-matching logic for admin page resolution, increasing reliability in navigation scenarios.
Chores
- Updated dependencies to use newer development versions of core resource packages across multiple components and bundles.
Tests
- Expanded and updated test coverage for new routing features and adjusted test expectations to reflect recent changes in URL formatting and route logic.

coderabbitai · 2025-07-18T13:01:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update introduces a routing backward compatibility (BC) layer with global and per-route enablement, adds resource metadata configuration files for admin resources, and updates dependency constraints for "sylius/resource" and "sylius/resource-bundle" to development versions. Routing conditions and configuration options are adjusted throughout the admin and core bundles to support fine-grained BC control.

Changes

Files/Areas	Change Summary
composer.json, src/Sylius/Bundle//composer.json, src/Sylius/Component//composer.json	Updated "sylius/resource" and/or "sylius/resource-bundle" dependency constraints to "^1.14@dev".
config/packages/_sylius.yaml, config/routes/sylius_resource.yaml	Introduced BC layer and resource mapping configuration; added service-based resource route.
src/Sylius/Bundle/CoreBundle/DependencyInjection/Configuration.php, .../SyliusCoreExtension.php	Added configuration tree and parameter handling for routing BC layer with per-route enable/disable.
src/Sylius/Bundle/CoreBundle/Resources/config/services.xml, .../Routing/RequestContext.php	Added a custom `RequestContext` service and class, with BC layer enablement logic.
src/Sylius/Bundle/CoreBundle/tests/DependencyInjection/ConfigurationTest.php, .../Routing/RequestContextTest.php	Added tests for BC layer configuration and custom request context logic.
src/Sylius/Bundle/AdminBundle/Resources/config/routing/.yml, .yaml	Added `condition` attributes to admin routes to check BC layer enablement for each route.
src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/*.php	Added resource metadata configuration files for admin resources (user, product, channel, etc.) with CRUD and bulk operations.
src/Sylius/Behat/Service/Resolver/CurrentPageResolver.php, .../CurrentPageResolverTest.php	Expanded route matching logic and updated test expectations for route name checks.
tests/Twig/RedirectPathExtensionTest.php	Adjusted test cases to remove trailing slashes from input and expected output paths.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SymfonyRouter
    participant SyliusRequestContext
    participant Config

    User->>SymfonyRouter: Request admin route
    SymfonyRouter->>SyliusRequestContext: Check route condition (isSyliusRoutingBcLayerEnabled)
    SyliusRequestContext->>Config: Lookup global and per-route BC layer enablement
    Config-->>SyliusRequestContext: Return enablement flag
    SyliusRequestContext-->>SymfonyRouter: Return true/false
    SymfonyRouter-->>User: Serve route if enabled, else 404

Possibly related PRs

Sylius/Sylius#18235: Updates "sylius/resource" and "sylius/resource-bundle" to "^1.14@dev" and introduces routing BC layer configuration and conditions.
Sylius/Sylius#18231: Updates dependencies and adds BC layer and resource metadata configuration, with routing conditionals for admin resources.

Suggested labels

Admin, Maintenance

Suggested reviewers

NoResponseMate

Poem

In the garden of code, a new path unfurled,
Routing BC toggles, per-route flags swirled.
Admin resources mapped, dependencies anew,
The rabbit hops forward, with a fresh point of view.
No trailing slashes, just clean, tidy trails—
May your routes be robust, and your tests never fail!
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

loic425 · 2025-07-18T13:17:11Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/customer.php

+            routeName: '_sylius_admin_customer_update',
+            redirectToRoute: 'sylius_admin_customer_update',
+        ),
+        new BulkDelete(


technically, legacy admin customer routing has a bulk delete operation... I'm wondering if we should add it or not.

github-actions · 2025-07-21T10:08:04Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

loic425 requested review from a team as code owners July 18, 2025 13:01

loic425 changed the base branch from 2.1 to new-routing July 18, 2025 13:01

loic425 changed the title ~~Admin customer crud~~ [New routing] Admin customers crud Jul 18, 2025

loic425 mentioned this pull request Jul 18, 2025

Using new routing system from Sylius resource bundle #18212

Open

loic425 commented Jul 18, 2025

View reviewed changes

[New routing] Admin customers crud

60394a9

loic425 force-pushed the admin-customer-crud branch from 8e6314f to 60394a9 Compare July 21, 2025 10:03

NoResponseMate approved these changes Jul 21, 2025

View reviewed changes

NoResponseMate merged commit 638aaf5 into Sylius:new-routing Jul 21, 2025
31 checks passed

loic425 deleted the admin-customer-crud branch July 21, 2025 11:45

coderabbitai bot mentioned this pull request Feb 6, 2026

[Maintenance] Allow doctrine/doctrine-bundle ^3.1 #18754

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[New routing] Admin customers crud#18239

[New routing] Admin customers crud#18239
NoResponseMate merged 1 commit intoSylius:new-routingfrom
loic425:admin-customer-crud

loic425 commented Jul 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 18, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

loic425 Jul 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

loic425 commented Jul 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

loic425 Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

loic425 commented Jul 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

loic425 Jul 18, 2025 •

edited

Loading

github-actions bot commented Jul 21, 2025 •

edited

Loading