[New routing] Admin countries crud#18235
Merged
NoResponseMate merged 1 commit intoSylius:new-routingfrom Jul 18, 2025
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update introduces a backward compatibility (BC) routing layer with global and per-route enablement, adds new resource metadata configurations for admin resources, and updates dependency constraints to allow development versions of the Sylius resource packages. Additional tests and service definitions support the new routing logic and configuration. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SymfonyRouter
participant SyliusRequestContext
participant Controller
User->>SymfonyRouter: Requests admin route (e.g., /admin/product)
SymfonyRouter->>SyliusRequestContext: Check if BC layer enabled for route
SyliusRequestContext->>SyliusRequestContext: isSyliusRoutingBcLayerEnabled('admin_product')
SyliusRequestContext-->>SymfonyRouter: Returns true/false
alt BC layer enabled
SymfonyRouter->>Controller: Route handled via legacy/BC logic
else BC layer disabled
SymfonyRouter->>Controller: Route handled via new resource metadata logic
end
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
5912d6f to
7a2fe93
Compare
NoResponseMate
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Tests