Using new routing system from Sylius resource bundle#18213
Draft
Using new routing system from Sylius resource bundle#18213
Conversation
Member
loic425
commented
Jul 7, 2025
| Q | A |
|---|---|
| Branch? | 2.1 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #18212 |
| License | MIT |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Check https://github.com/Sylius/Sylius/actions/runs/22478151407 for details. Available commands:
|
fde6308 to
179d7ea
Compare
Removes old upmerge paths (`1.14 -> 2.1`, `2.1 -> 2.2`) and sets up upmerge from `2.2` to `2.3`. Also updates the workflow file link in PR body to point to the `2.3` branch. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated the upmerge workflow configuration to refine version merge scope and refresh reference links. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This PR has been generated automatically. For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml). **Remember!** The upmerge should always be merged with using `Merge pull request` button. In case of conflicts, please resolve them manually with usign the following commands: ``` git fetch upstream gh pr checkout <this-pr-number> git merge upstream/2.3 -m "Resolve conflicts between 2.2 and 2.3" ``` If you use other name for the upstream remote, please replace `upstream` with the name of your remote pointing to the `Sylius/Sylius` repository. Once the conflicts are resolved, please run `git merge --continue` and push the changes to this PR. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated PSR-7 HTTP message dependency constraint to support both version 1.x and 2.x. * Corrected error page template file path case sensitivity references. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This PR has been generated automatically. For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml). **Remember!** The upmerge should always be merged with using `Merge pull request` button. In case of conflicts, please resolve them manually with usign the following commands: ``` git fetch upstream gh pr checkout <this-pr-number> git merge upstream/2.3 -m "Resolve conflicts between 2.2 and 2.3" ``` If you use other name for the upstream remote, please replace `upstream` with the name of your remote pointing to the `Sylius/Sylius` repository. Once the conflicts are resolved, please run `git merge --continue` and push the changes to this PR. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Consistent form field help display across widgets; improved admin taxon parent autocomplete (case-insensitive). * **Bug Fixes** * Fixed a template variable typo preventing form rendering. * Avoided incorrect category display when a main taxon name is missing. * **Localization** * Added/updated German translations for administration password reset and Romanian pluralization tweaks. * **Documentation** * Expanded contributor guidelines with detailed best practices and patterns. * **Tests** * Added unit and UI tests covering localhost resolution and taxonomy behaviors. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
* 2.2: Change application's version to v1.14.17-dev Generate changelog for v1.14.16 Change application's version to v1.14.16
* 2.2: Change application's version to v2.1.12-dev Generate changelog for v2.1.11 Change application's version to v2.1.11
Increases `timeout-minutes` from 15 to 20 minutes across all CI workflow files to reduce job cancellations. Ref: #18693 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Extended timeout limits for continuous integration and deployment jobs from 15 to 20 minutes across multiple workflow configurations to allow additional execution time. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This PR has been generated automatically. For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/2.3/.github/workflows/upmerge_pr.yaml). **Remember!** The upmerge should always be merged with using `Merge pull request` button. In case of conflicts, please resolve them manually with usign the following commands: ``` git fetch upstream gh pr checkout <this-pr-number> git merge upstream/2.3 -m "Resolve conflicts between 2.2 and 2.3" ``` If you use other name for the upstream remote, please replace `upstream` with the name of your remote pointing to the `Sylius/Sylius` repository. Once the conflicts are resolved, please run `git merge --continue` and push the changes to this PR. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Bumped release version and updated internal version identifiers for the next patch. * Added a new changelog entry for v2.2.2 (2026-01-20). * **Tests** * Updated frontend test metadata to run with the Mink Chromedriver setup. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
| Q | A |-----------------|----- | Branch? | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | - | License | MIT <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added GitHub Actions workflow automation for package splitting and distribution. * Introduced build script to generate package matrix configuration for automated package management. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Use new unified database format in e2e workflows: - database: "mysql:X.X" instead of database+database_version - database: "postgres:X.X" instead of postgresql+database_version - database: "mariadb:X.X" instead of mariadb+database_version - Remove DATABASE_URL from env (action sets it automatically)
Testing new BuildTestAppAction from `feature/auto-database-url` branch which introduces: - Unified database format: `mysql:8.4` instead of separate `database` + `database_version` - Automatic `DATABASE_URL` setting (no need to define in workflows) - Unified credentials (`sylius:sylius@sylius`) across all databases Changes in this PR: - Update ci_e2e-mysql.yaml, ci_e2e-pgsql.yaml, ci_e2e-mariadb.yaml - Remove `DATABASE_URL` from env sections - Use new `database: "type:version"` format Related: SyliusLabs/BuildTestAppAction#19 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * CI workflows updated to use automated database configuration for MariaDB, MySQL, and PostgreSQL. * Removed hard-coded database connection environment entries so jobs rely on generated configuration. * Standardized database selection input across matrix jobs and updated build steps to a newer build-action for more consistent test runs. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
| Q | A |-----------------|----- | Branch? | new-routing | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | partially #18212 | License | MIT <!-- - Bug fixes must be submitted against the 1.14 or 2.1 branch - Features and deprecations must be submitted against the 2.2 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html -->
Co-authored-by: Jan Góralski <jan.wojciech.goralski@gmail.com>
| Q | A |-----------------|----- | Branch? | new-routing | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | partially #18212 | License | MIT <!-- - Bug fixes must be submitted against the 1.14 or 2.1 branch - Features and deprecations must be submitted against the 2.2 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Inspired by the [ResetPasswordAction](https://github.com/Sylius/Sylius/blob/0f2e2b33dc222b27d911e73a41afc226027b877d/src/Sylius/Bundle/AdminBundle/Action/Account/ResetPasswordAction.php) from the admin panel.
| Q | A |-----------------|----- | Branch? | new-routing | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | partially #18212 | License | MIT <!-- - Bug fixes must be submitted against the 1.14 or 2.1 branch - Features and deprecations must be submitted against the 2.2 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html -->
| Q | A |-----------------|----- | Branch? | new-routing | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | partially #18212 | License | MIT <!-- - Bug fixes must be submitted against the 1.14 or 2.1 branch - Features and deprecations must be submitted against the 2.2 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.